Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 1832613003: Revise layer, extension and feature setup for Vulkan (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revise layer, extension and feature setup for Vulkan Moves all the extension setup logic into GrVkBackendContext, and pass extension and feature information to Skia via flags. Also adds version information to GrVkBackendContext. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1832613003 TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/fd7bd45ac2178ce6b4a390f517f605750aaef6c8

Patch Set 1 #

Patch Set 2 : Remove extra def of ENABLE_VK_LAYERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -417 lines) Patch
M include/gpu/vk/GrVkBackendContext.h View 2 chunks +14 lines, -0 lines 0 comments Download
M include/gpu/vk/GrVkInterface.h View 3 chunks +2 lines, -19 lines 0 comments Download
M src/gpu/vk/GrVkBackendContext.cpp View 8 chunks +64 lines, -103 lines 0 comments Download
M src/gpu/vk/GrVkCaps.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 5 chunks +12 lines, -14 lines 0 comments Download
M src/gpu/vk/GrVkExtensions.h View 1 chunk +6 lines, -53 lines 0 comments Download
M src/gpu/vk/GrVkExtensions.cpp View 7 chunks +41 lines, -170 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkInterface.cpp View 4 chunks +30 lines, -42 lines 0 comments Download
M src/gpu/vk/GrVkUtil.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jvanverth1
4 years, 9 months ago (2016-03-24 18:54:53 UTC) #3
egdaniel
lgtm
4 years, 9 months ago (2016-03-24 22:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832613003/20001
4 years, 9 months ago (2016-03-25 13:12:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/8083)
4 years, 9 months ago (2016-03-25 13:14:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832613003/20001
4 years, 9 months ago (2016-03-25 13:16:33 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 13:29:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fd7bd45ac2178ce6b4a390f517f605750aaef6c8

Powered by Google App Engine
This is Rietveld 408576698