Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1832613002: Add transformation, canvas state, shadow to OffscreenCanvasRenderingContext2D (Closed)

Created:
4 years, 9 months ago by xlai (Olivia)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add transformation, canvas state, shadow to OffscreenCanvasRenderingContext2D BUG=563856 Committed: https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5 Cr-Commit-Position: refs/heads/master@{#385185}

Patch Set 1 #

Patch Set 2 : Rebase with master #

Patch Set 3 : More OffscreenCanvas 2d features #

Messages

Total messages: 15 (6 generated)
xlai (Olivia)
After this patch (https://codereview.chromium.org/1844083002/) is landed, we can now add more features.
4 years, 8 months ago (2016-04-01 20:08:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832613002/40001
4 years, 8 months ago (2016-04-04 17:02:08 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-04 17:02:10 UTC) #6
xlai (Olivia)
Adding xidachen@ and ajuma@ to reviewers. Does anyone have time today to help me review ...
4 years, 8 months ago (2016-04-05 14:13:29 UTC) #8
ajuma
lgtm
4 years, 8 months ago (2016-04-05 15:02:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832613002/40001
4 years, 8 months ago (2016-04-05 15:16:04 UTC) #11
Justin Novosad
lgtm 2
4 years, 8 months ago (2016-04-05 15:45:33 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 16:18:32 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 16:20:26 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b697944deb9405ee4e15df5b942a8f8390817a5
Cr-Commit-Position: refs/heads/master@{#385185}

Powered by Google App Engine
This is Rietveld 408576698