Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1832603002: Properly handle unsigned literals, fix typing issue with unary +. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly handle unsigned literals, fix typing issue with unary +. Properly convert unsigned literals. Forbid using unary + on a kAsmInt. Forbid multiplies other than * 1.0 as being equivalent to unary +. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=test-asm-validator,asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/942ed114880b1cf1a72f9aa38d20759dd835b98e Cr-Commit-Position: refs/heads/master@{#35046}

Patch Set 1 #

Patch Set 2 : drop print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -30 lines) Patch
M src/typing-asm.cc View 1 1 chunk +17 lines, -2 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 1 chunk +25 lines, -26 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 4 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bradn
4 years, 9 months ago (2016-03-23 20:16:12 UTC) #2
titzer
lgtm
4 years, 9 months ago (2016-03-23 20:37:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832603002/20001
4 years, 9 months ago (2016-03-23 20:39:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832603002/20001
4 years, 9 months ago (2016-03-23 23:16:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 23:20:01 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 23:21:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/942ed114880b1cf1a72f9aa38d20759dd835b98e
Cr-Commit-Position: refs/heads/master@{#35046}

Powered by Google App Engine
This is Rietveld 408576698