Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 18326020: Android: adds a few third-party scripts for stack symbolization. (Closed)

Created:
7 years, 5 months ago by bulach
Modified:
7 years, 5 months ago
Reviewers:
palmer, cjhopman, open-source-third-party-reviews, Daniel Berlin
CC:
chromium-reviews
Visibility:
Public.

Description

Android: adds a few third-party scripts for stack symbolization. Pick a few utility scripts from https://android.googlesource.com/platform/development/+/master/scripts/ These are used for symbolizing crash stacks on android. BUG=234973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210833

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, --1 lines) Patch
A + third_party/android_platform/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/android_platform/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/android_platform/README.chromium View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/android_platform/development/scripts/stack View 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/android_platform/development/scripts/stack_core.py View 1 chunk +196 lines, -0 lines 0 comments Download
A third_party/android_platform/development/scripts/symbol.py View 1 chunk +344 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
7 years, 5 months ago (2013-07-03 17:44:14 UTC) #1
cjhopman
lgtm
7 years, 5 months ago (2013-07-03 18:54:54 UTC) #2
Daniel Berlin
LGTM for third party open source
7 years, 5 months ago (2013-07-03 20:37:07 UTC) #3
bulach
+palmer for security (sorry about the spam :) but in the past I had problems ...
7 years, 5 months ago (2013-07-09 11:05:43 UTC) #4
palmer
LGTM. Yeah, it's always better to name specific people. Chrome for Android security reviewers are ...
7 years, 5 months ago (2013-07-09 19:17:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/18326020/3001
7 years, 5 months ago (2013-07-10 10:48:32 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 13:23:16 UTC) #7
Message was sent while issue was closed.
Change committed as 210833

Powered by Google App Engine
This is Rietveld 408576698