Don't allow negative date components in ParseCertificateDate(), or ones starting with a plus.

net/cert/x509_cert_types_unittest.cc

Index: net/cert/x509_cert_types_unittest.cc
diff --git a/net/cert/x509_cert_types_unittest.cc b/net/cert/x509_cert_types_unittest.cc
index f3bf8fccb11cce3e02cee9c5abf32497c5a40fe3..50275f0eb010f7cb253fab4ca4c78ec7500c93e5 100644
--- a/net/cert/x509_cert_types_unittest.cc
+++ b/net/cert/x509_cert_types_unittest.cc
@@ -148,50 +148,40 @@ const struct CertDateTestData {
   bool is_valid;
   base::Time::Exploded expected_result;
 } kCertDateTimeData[] = {
-  { CERT_DATE_FORMAT_UTC_TIME,
-    "120101000000Z",
-    true,
-    { 2012, 1, 0, 1, 0, 0, 0 } },
-  { CERT_DATE_FORMAT_GENERALIZED_TIME,
-    "20120101000000Z",
-    true,
-    { 2012, 1, 0, 1, 0, 0, 0 } },
-  { CERT_DATE_FORMAT_UTC_TIME,
-    "490101000000Z",
-    true,
-    { 2049, 1, 0, 1, 0, 0, 0 } },
-  { CERT_DATE_FORMAT_UTC_TIME,
-    "500101000000Z",
-    true,
-    { 1950, 1, 0, 1, 0, 0, 0 } },
-  { CERT_DATE_FORMAT_GENERALIZED_TIME,
-    "19500101000000Z",
-    true,
-    { 1950, 1, 0, 1, 0, 0, 0 } },
-  { CERT_DATE_FORMAT_UTC_TIME,
-    "AB0101000000Z",
-    false,
-    { 0 } },
-  { CERT_DATE_FORMAT_GENERALIZED_TIME,
-    "19AB0101000000Z",
-    false,
-    { 0 } },
-  { CERT_DATE_FORMAT_UTC_TIME,
-    "",
-    false,
-    { 0 } },
-  { CERT_DATE_FORMAT_UTC_TIME,
-    "A",
-    false,
-    { 0 } },
- { CERT_DATE_FORMAT_GENERALIZED_TIME,
-    "20121301000000Z",
-    false,
-    { 0 } },
- { CERT_DATE_FORMAT_GENERALIZED_TIME,
-    "20120101123000Z",
-    true,
-    { 2012, 1, 0, 1, 12, 30, 0 } },
+    {CERT_DATE_FORMAT_UTC_TIME,
+     "120101000000Z",
+     true,
+     {2012, 1, 0, 1, 0, 0, 0}},
+    {CERT_DATE_FORMAT_UTC_TIME, "-90101000000Z", false, {0}},
+    {CERT_DATE_FORMAT_UTC_TIME, "+90101000000Z", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME, "2012+1+1000000Z", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME, "2012-101000000Z", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME, "2012 101000000Z", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME,
+     "20120101000000Z",
+     true,
+     {2012, 1, 0, 1, 0, 0, 0}},
+    {CERT_DATE_FORMAT_UTC_TIME,
+     "490101000000Z",
+     true,
+     {2049, 1, 0, 1, 0, 0, 0}},
+    {CERT_DATE_FORMAT_UTC_TIME,
+     "500101000000Z",
+     true,
+     {1950, 1, 0, 1, 0, 0, 0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME,
+     "19500101000000Z",
+     true,
+     {1950, 1, 0, 1, 0, 0, 0}},
+    {CERT_DATE_FORMAT_UTC_TIME, "AB0101000000Z", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME, "19AB0101000000Z", false, {0}},
+    {CERT_DATE_FORMAT_UTC_TIME, "", false, {0}},
+    {CERT_DATE_FORMAT_UTC_TIME, "A", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME, "20121301000000Z", false, {0}},
+    {CERT_DATE_FORMAT_GENERALIZED_TIME,
+     "20120101123000Z",
+     true,
+     {2012, 1, 0, 1, 12, 30, 0}},
 };
 
 // GTest pretty printer.