Gpu Image Decode Controller

cc/tiles/gpu_image_decode_controller_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/tiles/gpu_image_decode_controller.h"
+
+#include "cc/playback/draw_image.h"
+#include "cc/raster/tile_task_runner.h"
+#include "cc/test/test_context_provider.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace cc {
+namespace {
+
+skia::RefPtr<SkImage> CreateImage(int width, int height) {
+  SkImageInfo info = SkImageInfo::MakeN32Premul(width, height);
+  SkBitmap bitmap;
+  bitmap.allocPixels(info);
+  return skia::AdoptRef(SkImage::NewFromBitmap(bitmap));
+}
+
+SkMatrix CreateMatrix(const SkSize& scale, bool is_decomposable) {
+  SkMatrix matrix;
+  matrix.setScale(scale.width(), scale.height());
+
+  if (!is_decomposable) {
+    // Perspective is not decomposable, add it.
+    matrix[SkMatrix::kMPersp0] = 0.1f;
+  }
+
+  return matrix;
+}
+
+void ScheduleTask(ImageDecodeTask* task) {
+  task->WillSchedule();
+  task->ScheduleOnOriginThread(nullptr);
+  task->DidSchedule();
+}
+
+void RunTask(ImageDecodeTask* task) {
+  task->WillRun();
+  task->RunOnWorkerThread();
+  task->DidRun();
+}
+
+void CompleteTask(ImageDecodeTask* task) {
+  task->WillComplete();
+  task->CompleteOnOriginThread(nullptr);
+  task->DidComplete();
+}
+
+void ProcessTask(ImageDecodeTask* task) {
+  ScheduleTask(task);
+  RunTask(task);
+  CompleteTask(task);
+}
+
+TEST(GpuImageDecodeControllerTest, GetTaskForImageSameImage) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  bool is_decomposable = true;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+  uint64_t prepare_tiles_id = 1;
+
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task);
+
+  DrawImage another_draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));

[vmpstr, 2016/03/28 23:55:53]

Can you change the scale here as well, since it should still result in the same
task?

[ericrk, 2016/03/29 23:11:30]

sure.

+  scoped_refptr<ImageDecodeTask> another_task;
+  need_unref = controller.GetTaskForImageAndRef(
+      another_draw_image, prepare_tiles_id, &another_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task.get() == another_task.get());
+
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, GetTaskForImageDifferentImage) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> first_image = CreateImage(100, 100);
+  DrawImage first_draw_image(
+      first_image.get(),
+      SkIRect::MakeWH(first_image->width(), first_image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> first_task;
+  bool need_unref = controller.GetTaskForImageAndRef(
+      first_draw_image, prepare_tiles_id, &first_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(first_task);
+
+  skia::RefPtr<SkImage> second_image = CreateImage(100, 100);
+  DrawImage second_draw_image(
+      second_image.get(),
+      SkIRect::MakeWH(second_image->width(), second_image->height()), quality,
+      CreateMatrix(SkSize::Make(0.25f, 0.25f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> second_task;
+  need_unref = controller.GetTaskForImageAndRef(second_draw_image,
+                                                prepare_tiles_id, &second_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(second_task);
+  EXPECT_TRUE(first_task.get() != second_task.get());
+
+  controller.UnrefImage(first_draw_image);
+  controller.UnrefImage(second_draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, GetTaskForImageAlreadyDecoded) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task);
+  EXPECT_TRUE(task->dependency());
+
+  ProcessTask(task->dependency().get());
+  ScheduleTask(task.get());
+  RunTask(task.get());
+
+  scoped_refptr<ImageDecodeTask> another_task;
+  need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
+                                                &another_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_FALSE(another_task);
+
+  CompleteTask(task.get());
+
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, GetTaskForImageCanceledGetsNewTask) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task);
+
+  ProcessTask(task->dependency().get());
+  ScheduleTask(task.get());
+
+  scoped_refptr<ImageDecodeTask> another_task;
+  need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
+                                                &another_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(another_task.get() == task.get());
+
+  // Didn't run the task, complete it (it was canceled).
+  CompleteTask(task.get());
+
+  // Fully cancel everything (so the raster would unref things).
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
+
+  // Here a new task is created.
+  scoped_refptr<ImageDecodeTask> third_task;
+  need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
+                                                &third_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(third_task);
+  EXPECT_FALSE(third_task.get() == task.get());
+
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest,
+     GetTaskForImageCanceledWhileReffedGetsNewTask) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task);
+
+  ProcessTask(task->dependency().get());
+  ScheduleTask(task.get());
+
+  scoped_refptr<ImageDecodeTask> another_task;
+  need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
+                                                &another_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(another_task.get() == task.get());
+
+  // Didn't run the task, complete it (it was canceled).
+  CompleteTask(task.get());
+
+  // Note that here, everything is reffed, but a new task is created. This is
+  // possible with repeated schedule/cancel operations.
+  scoped_refptr<ImageDecodeTask> third_task;
+  need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
+                                                &third_task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(third_task);
+  EXPECT_FALSE(third_task.get() == task.get());
+
+  // 3 Unrefs!
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, GetDecodedImageForDraw) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task);
+
+  ProcessTask(task->dependency().get());
+  ProcessTask(task.get());
+
+  // Must hold context lock before calling GetDecodedImageForDraw /
+  // DrawWithImageFinished.
+  ContextProvider::ScopedContextLock context_lock(context_provider.get());
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_TRUE(decoded_draw_image.image());
+  EXPECT_TRUE(decoded_draw_image.image()->isTextureBacked());
+  EXPECT_FALSE(decoded_draw_image.is_at_raster_decode());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, GetLargeDecodedImageForDraw) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(1, 24000);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(need_unref);
+  EXPECT_TRUE(task);
+
+  ProcessTask(task->dependency().get());
+  ProcessTask(task.get());
+
+  // Must hold context lock before calling GetDecodedImageForDraw /
+  // DrawWithImageFinished.
+  ContextProvider::ScopedContextLock context_lock(context_provider.get());
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_TRUE(decoded_draw_image.image());
+  EXPECT_FALSE(decoded_draw_image.image()->isTextureBacked());
+  EXPECT_FALSE(decoded_draw_image.is_at_raster_decode());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, GetDecodedImageForDrawAtRasterDecode) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  controller.SetCachedItemLimitForTesting(0);
+  controller.SetCachedBytesLimitForTesting(0);
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_FALSE(need_unref);
+  EXPECT_FALSE(task);
+
+  // Must hold context lock before calling GetDecodedImageForDraw /
+  // DrawWithImageFinished.
+  ContextProvider::ScopedContextLock context_lock(context_provider.get());
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_TRUE(decoded_draw_image.image());
+  EXPECT_TRUE(decoded_draw_image.image()->isTextureBacked());
+  EXPECT_TRUE(decoded_draw_image.is_at_raster_decode());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, AtRasterUsedDirectlyIfSpaceAllows) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  controller.SetCachedItemLimitForTesting(0);
+  controller.SetCachedBytesLimitForTesting(0);
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_FALSE(need_unref);
+  EXPECT_FALSE(task);
+
+  // Must hold context lock before calling GetDecodedImageForDraw /
+  // DrawWithImageFinished.
+  ContextProvider::ScopedContextLock context_lock(context_provider.get());
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_TRUE(decoded_draw_image.image());
+  EXPECT_TRUE(decoded_draw_image.image()->isTextureBacked());
+  EXPECT_TRUE(decoded_draw_image.is_at_raster_decode());
+
+  controller.SetCachedItemLimitForTesting(1000);
+  controller.SetCachedBytesLimitForTesting(96 * 1024 * 1024);
+
+  scoped_refptr<ImageDecodeTask> another_task;
+  bool another_task_needs_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(another_task_needs_unref);
+  EXPECT_FALSE(another_task);
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+  controller.UnrefImage(draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest,
+     GetDecodedImageForDrawAtRasterDecodeMultipleTimes) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  controller.SetCachedItemLimitForTesting(0);
+  controller.SetCachedBytesLimitForTesting(0);
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.5f, 0.5f), is_decomposable));
+
+  // Must hold context lock before calling GetDecodedImageForDraw /
+  // DrawWithImageFinished.
+  ContextProvider::ScopedContextLock context_lock(context_provider.get());
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_TRUE(decoded_draw_image.image());
+  EXPECT_TRUE(decoded_draw_image.image()->isTextureBacked());
+  EXPECT_TRUE(decoded_draw_image.is_at_raster_decode());
+
+  DecodedDrawImage another_decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_EQ(decoded_draw_image.image()->uniqueID(),
+            another_decoded_draw_image.image()->uniqueID());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+  controller.DrawWithImageFinished(draw_image, another_decoded_draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, ZeroSizedImagesAreSkipped) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()), quality,
+      CreateMatrix(SkSize::Make(0.f, 0.f), is_decomposable));
+
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_FALSE(task);
+  EXPECT_FALSE(need_unref);
+
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_FALSE(decoded_draw_image.image());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, NonOverlappingSrcRectImagesAreSkipped) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeXYWH(150, 150, image->width(), image->height()),
+      quality, CreateMatrix(SkSize::Make(1.f, 1.f), is_decomposable));
+
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_FALSE(task);
+  EXPECT_FALSE(need_unref);
+
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_FALSE(decoded_draw_image.image());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+}
+
+TEST(GpuImageDecodeControllerTest, CancelledTasksDoNotCountAgainstBudget) {
+  auto context_provider = TestContextProvider::Create();
+  context_provider->BindToCurrentThread();
+  GpuImageDecodeController controller(context_provider.get(),
+                                      ResourceFormat::RGBA_8888);
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kHigh_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeXYWH(0, 0, image->width(), image->height()),
+      quality, CreateMatrix(SkSize::Make(1.f, 1.f), is_decomposable));
+
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_NE(0u, controller.GetBytesUsedForTesting());
+  EXPECT_TRUE(task);
+  EXPECT_TRUE(need_unref);
+
+  ScheduleTask(task->dependency().get());
+  CompleteTask(task->dependency().get());
+  ScheduleTask(task.get());
+  CompleteTask(task.get());
+
+  controller.UnrefImage(draw_image);
+  EXPECT_EQ(0u, controller.GetBytesUsedForTesting());
+}
+
+}  // namespace
+}  // namespace cc