Gpu Image Decode Controller

cc/resources/resource_format.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/resource_format.h"
 
 #include "third_party/khronos/GLES2/gl2.h"
 #include "third_party/khronos/GLES2/gl2ext.h"
 
 namespace cc {
@@ skipping 11 matching lines @@
     case RGB_565:
     case RED_8:
     case LUMINANCE_F16:
       NOTREACHED();
       break;
   }
   NOTREACHED();
   return kN32_SkColorType;
 }
 
+SkColorType ResourceFormatToClosestSkColorType(ResourceFormat format) {

[vmpstr, 2016/03/28 23:55:52]

The only difference between this function and the one above is an extra
NOTREACHED(). Do you think the NOTREACHED is important in those cases? I'm kind
of hoping that we can just keep one of the functions. 

[ericrk, 2016/03/29 23:11:29]

I think we can just drop the above one and use this version only - the above is
used in exactly one place,  so seems safe.

+  // Use kN32_SkColorType if there is no corresponding SkColorType.
+  switch (format) {
+    case RGBA_4444:
+      return kARGB_4444_SkColorType;
+    case RGBA_8888:
+    case BGRA_8888:
+      return kN32_SkColorType;
+    case ALPHA_8:
+      return kAlpha_8_SkColorType;
+    case RGB_565:
+      return kRGB_565_SkColorType;
+    case LUMINANCE_8:
+      return kGray_8_SkColorType;
+    case ETC1:
+    case RED_8:
+    case LUMINANCE_F16:
+      return kN32_SkColorType;
+  }
+  NOTREACHED();
+  return kN32_SkColorType;
+}
+
 int BitsPerPixel(ResourceFormat format) {
   switch (format) {
     case BGRA_8888:
     case RGBA_8888:
       return 32;
     case RGBA_4444:
     case RGB_565:
     case LUMINANCE_F16:
       return 16;
     case ALPHA_8:
@@ skipping 87 matching lines @@
     case ETC1:
     case RED_8:
     case LUMINANCE_F16:
       return false;
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace cc