Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1832533002:
force no SSE on iOS simulator (Closed)
Descriptionforce no SSE on iOS simulator
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1832533002
Committed: https://skia.googlesource.com/skia/+/c60bfbb1b58ceea872f12bc8b62f2654bb47fbaa
Patch Set 1 #Patch Set 2 : better #Messages
Total messages: 20 (8 generated)
Description was changed from ========== force no SSE on iOS simulator BUG=skia: ========== to ========== force no SSE on iOS simulator BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + benjaminwagner@google.com
(I think that's as green as that bot gets right now.)
On 2016/03/23 at 19:03:24, mtklein wrote: > In public.bzl, we define SK_BUILD_FOR_IOS, not TARGET_OS_IPHONE/TARGET_IPHONE_SIMULATOR.
On 2016/03/23 19:08:53, Ben Wagner wrote: > On 2016/03/23 at 19:03:24, mtklein wrote: > > > > In public.bzl, we define SK_BUILD_FOR_IOS, not > TARGET_OS_IPHONE/TARGET_IPHONE_SIMULATOR. Does the compiler not define those for us? I'm surprised we need to define SK_BUILD_FOR_IOS.
On 2016/03/23 19:10:30, mtklein wrote: > On 2016/03/23 19:08:53, Ben Wagner wrote: > > On 2016/03/23 at 19:03:24, mtklein wrote: > > > > > > > In public.bzl, we define SK_BUILD_FOR_IOS, not > > TARGET_OS_IPHONE/TARGET_IPHONE_SIMULATOR. > > Does the compiler not define those for us? I'm surprised we need to define > SK_BUILD_FOR_IOS. Well, whatever, no need to complicate this with that. Have a look now?
On 2016/03/23 at 19:10:30, mtklein wrote: > On 2016/03/23 19:08:53, Ben Wagner wrote: > > On 2016/03/23 at 19:03:24, mtklein wrote: > > > > > > > In public.bzl, we define SK_BUILD_FOR_IOS, not > > TARGET_OS_IPHONE/TARGET_IPHONE_SIMULATOR. > > Does the compiler not define those for us? I'm surprised we need to define SK_BUILD_FOR_IOS. No clue, sorry.
lgtm
The CQ bit was checked by benjaminwagner@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832533002/20001
mtklein@google.com changed reviewers: + mtklein@google.com
lgtm!
Description was changed from ========== force no SSE on iOS simulator BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== force no SSE on iOS simulator TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832533002/20001
Message was sent while issue was closed.
Description was changed from ========== force no SSE on iOS simulator TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== force no SSE on iOS simulator TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c60bfbb1b58ceea872f12bc8b62f2654bb47fbaa ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/c60bfbb1b58ceea872f12bc8b62f2654bb47fbaa |
