Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183253005: Change the streamlined hosted app creation buttons text to "Add shortcut to this website" (Closed)

Created:
6 years, 9 months ago by calamity
Modified:
6 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_icon_to_dialog
Visibility:
Public.

Description

Change the streamlined hosted app creation buttons text to "Add shortcut to this website" This CL changes the string in the streamlined hosted app creation button in order to be less inconsistent with the actual dialog which appears with the title "Add shortcut". BUG=318607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
calamity
6 years, 9 months ago (2014-03-06 07:29:44 UTC) #1
benwells
lgtm
6 years, 9 months ago (2014-03-06 22:29:15 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 9 months ago (2014-03-06 23:47:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/183253005/1
6 years, 9 months ago (2014-03-06 23:58:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 02:26:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 02:26:49 UTC) #6
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 9 months ago (2014-03-07 03:22:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/183253005/1
6 years, 9 months ago (2014-03-07 03:25:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:47:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 05:47:57 UTC) #10
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 9 months ago (2014-03-07 06:11:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/183253005/1
6 years, 9 months ago (2014-03-07 06:15:47 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 11:37:21 UTC) #13
Message was sent while issue was closed. 
Change committed as 255585

Powered by Google App Engine
This is Rietveld 408576698