Issue 183253003: Consistently use ExceptionState::throwTypeError().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183253003: Consistently use ExceptionState::throwTypeError(). (Closed)

Created:
6 years, 9 months ago by sof

Modified:
6 years, 9 months ago

Reviewers:
haraken, Mike West

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, Rik, adamk+blink_chromium.org, Inactive, aandrey+blink_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Consistently use ExceptionState::throwTypeError(). Prefer this helper function when throwing TypeErrors. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168247

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -18 lines)			Patch
M	Source/core/dom/MutationObserver.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/testing/Internals.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/DOMParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLSerializer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/imagebitmap/ImageBitmapFactories.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/webmidi/MIDIOutput.cpp	View	3 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 5 (0 generated)

sof

When you have a moment, please take a look. Just making the code a bit ...

6 years, 9 months ago (2014-03-01 12:14:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/183253003/1

6 years, 9 months ago (2014-03-01 17:14:24 UTC) #4

Message was sent while issue was closed.

Change committed as 168247