Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issue 18325021: Revert 208403 "Remove MediaStreamDeviceThread in favor of using ..." (Closed)

Created:
7 years, 5 months ago by DaleCurtis
Modified:
7 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 208403 "Remove MediaStreamDeviceThread in favor of using ..." > Remove MediaStreamDeviceThread in favor of using AudioThread. > > Doesn't seem to be a good reason for this thread; remove it in favor > of using the thread provided by the AudioManager. > > This also ensures we don't issue CoreAudio calls on a thread other > than the main thread for OSX. > > Bonus: Making this change required converting several unittests to use > the new TestBrowserThreadBundle instead of manually creating threads. > > BUG=158170, 256945 > TEST=unit tests pass. device changes work. > > Review URL: https://chromiumcodereview.appspot.com/17444005 This leaves in the UMA statistics and test cleanup and only reverts the device thread removal. TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210027

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M trunk/src/content/browser/renderer_host/media/media_stream_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/media/media_stream_manager.cc View 4 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
7 years, 5 months ago (2013-07-03 19:27:36 UTC) #1
DaleCurtis
7 years, 5 months ago (2013-07-03 19:51:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r210027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698