Add isActive field on Timer.

tools/dom/src/native_DOMImplementation.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of html;
 
 class _Utils {
   static double dateTimeToDouble(DateTime dateTime) =>
       dateTime.millisecondsSinceEpoch.toDouble();
   static DateTime doubleToDateTime(double dateTime) {
@@ skipping 182 matching lines @@
 
 final _printClosure = window.console.log;
 final _pureIsolatePrintClosure = (s) {
   _sendToHelperIsolate([_PRINT, s], null);
 };
 
 final _forwardingPrintClosure = _Utils.forwardingPrint;
 
 class _Timer implements Timer {
   final canceller;
+  bool _isDone = false;
 
   _Timer(this.canceller);
 
-  void cancel() { canceller(); }
+  factory _Timer.timerFactoryClosure(int milliSeconds,

[floitsch, 2013/07/01 17:50:56]

Make this the default constructor. If you use the `canceller` field as indicator
if the timer is active (see below) then you can make this a non-factory
constructor.

[zarah, 2013/07/02 11:22:01]

Done.

+                                     void callback(Timer timer),
+                                     bool repeating) {
+    var maker;
+    var canceller;
+    if (repeating) {
+      maker = window._setInterval;
+      canceller = window._clearInterval;
+    } else {
+      maker = window._setTimeout;
+      canceller = window._clearTimeout;
+    }
+    Timer timer;
+    final int id = maker(() { _isDone = true; callback(timer);}, milliSeconds);

[floitsch, 2013/07/01 17:50:56]

Don't put more than one statement on the same line.

You could also use the _canceller field (which should be private and called
"canceler") as indication instead of having an extra boolean field.

[zarah, 2013/07/02 11:22:01]

Done.

+    timer = new _Timer(() { canceller(id); });

[floitsch, 2013/07/01 17:50:56]

Nit: it is annoying to me that we wrap the canceler in two closures.
Make `id` non-final, move it above the if and create the full canceler directly:
canceler = () => window._clearInterval(id);

[zarah, 2013/07/02 11:22:01]

Done.

+    return timer;
+  }
+
+  void cancel() {
+    _isDone = true;
+    canceller();
+  }
+
+  bool get isActive => !_isDone;
 }
 
-get _timerFactoryClosure => (int milliSeconds, void callback(Timer timer), bool repeating) {
-  var maker;
-  var canceller;
-  if (repeating) {
-    maker = window._setInterval;
-    canceller = window._clearInterval;
-  } else {
-    maker = window._setTimeout;
-    canceller = window._clearTimeout;
-  }
-  Timer timer;
-  final int id = maker(() { callback(timer); }, milliSeconds);
-  timer = new _Timer(() { canceller(id); });
-  return timer;
+get _timerFactoryClosure =>
+    (int milliSeconds, void callback(Timer timer), bool repeating) {
+  return _Timer.timerFactoryClosure(milliseconds, callback, repeating);
 };
 
 class _PureIsolateTimer implements Timer {
+  bool _isDone = false;
   final ReceivePort _port = new ReceivePort();
   SendPort _sendPort; // Effectively final.
 
   static SendPort _SEND_PORT;
 
   _PureIsolateTimer(int milliSeconds, callback, repeating) {
     _sendPort = _port.toSendPort();
     _port.receive((msg, replyTo) {
       assert(msg == _TIMER_PING);
+      _isDone = !repeating;
       callback(this);
       if (!repeating) _cancel();
     });
 
     _send([_NEW_TIMER, milliSeconds, repeating]);
   }
 
   void cancel() {
     _cancel();
     _send([_CANCEL_TIMER]);
   }
 
   void _cancel() {
+    _isDone = true;
     _port.close();
   }
 
   _send(msg) {
     _sendToHelperIsolate(msg, _sendPort);
   }
+
+  bool get isActive => !_isDone;
 }
 
 get _pureIsolateTimerFactoryClosure =>
     ((int milliSeconds, void callback(Timer time), bool repeating) =>
         new _PureIsolateTimer(milliSeconds, callback, repeating));