Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: content/child/db_message_filter.cc

Issue 1832473002: WebSQL: Use url::Origin rather than database identifiers for IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/db_message_filter.cc
diff --git a/content/child/db_message_filter.cc b/content/child/db_message_filter.cc
index 9e65a38fc054c7694cb188746a87e9ae55eeb8d4..5177c1856cf208fb8ded06a8d943436edbbd31ca 100644
--- a/content/child/db_message_filter.cc
+++ b/content/child/db_message_filter.cc
@@ -10,23 +10,13 @@
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebURL.h"
#include "third_party/WebKit/public/web/WebDatabase.h"
+#include "url/origin.h"
using blink::WebSecurityOrigin;
using blink::WebString;
namespace content {
-namespace {
-
-// TODO(jsbell): Pass url::Origin over IPC instead of database identifier/GURL.
-// https://crbug.com/591482
-WebSecurityOrigin OriginFromIdentifier(const std::string& identifier) {
- return WebSecurityOrigin::create(
- storage::GetOriginFromIdentifier(identifier));
-}
-
-} // namespace
-
DBMessageFilter::DBMessageFilter() {
}
@@ -45,31 +35,25 @@ bool DBMessageFilter::OnMessageReceived(const IPC::Message& message) {
return handled;
}
-void DBMessageFilter::OnDatabaseUpdateSize(const std::string& origin_identifier,
+void DBMessageFilter::OnDatabaseUpdateSize(const url::Origin& origin,
const base::string16& database_name,
int64_t database_size) {
- blink::WebDatabase::updateDatabaseSize(
- OriginFromIdentifier(origin_identifier), database_name, database_size);
+ blink::WebDatabase::updateDatabaseSize(origin, database_name, database_size);
}
-void DBMessageFilter::OnDatabaseUpdateSpaceAvailable(
- const std::string& origin_identifier,
- int64_t space_available) {
- blink::WebDatabase::updateSpaceAvailable(
- OriginFromIdentifier(origin_identifier), space_available);
+void DBMessageFilter::OnDatabaseUpdateSpaceAvailable(const url::Origin& origin,
+ int64_t space_available) {
+ blink::WebDatabase::updateSpaceAvailable(origin, space_available);
}
-void DBMessageFilter::OnDatabaseResetSpaceAvailable(
- const std::string& origin_identifier) {
- blink::WebDatabase::resetSpaceAvailable(
- OriginFromIdentifier(origin_identifier));
+void DBMessageFilter::OnDatabaseResetSpaceAvailable(const url::Origin& origin) {
+ blink::WebDatabase::resetSpaceAvailable(origin);
}
void DBMessageFilter::OnDatabaseCloseImmediately(
- const std::string& origin_identifier,
+ const url::Origin& origin,
const base::string16& database_name) {
- blink::WebDatabase::closeDatabaseImmediately(
- OriginFromIdentifier(origin_identifier), database_name);
+ blink::WebDatabase::closeDatabaseImmediately(origin, database_name);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698