Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1832463002:
Add <algorithm> header to audio_directive_list.cc (Closed)
DescriptionAdd <algorithm> header to audio_directive_list.cc
The code is using std::{make,push}_heap, but doesn't include the <algorithm> header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
Committed: https://crrev.com/231c6b3c1a21805754320fe9d72eaf8900abc6eb
Cr-Commit-Position: refs/heads/master@{#382902}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
Description was changed from
==========
Add <algorithm> header to audio_directive_list.cc
The code is using std::find_if, but doesn't include the <algorithm> header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
==========
to
==========
Add <algorithm> header to audio_directive_list.cc
The code is using std::{make,push}_heap, but doesn't include the <algorithm>
header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
==========
xyzzyz@chromium.org changed reviewers: + ckehoe@chromium.org, xiyuan@chromium.org
xiyuan@chromium.org: Please review changes in ckehoe@chromium.org: Please review changes in
Lgtm On Wed, Mar 23, 2016, 11:34 AM <xyzzyz@chromium.org> wrote: > Reviewers: xiyuan, Charlie > CL: https://codereview.chromium.org/1832463002/ > > Message: > xiyuan@chromium.org: Please review changes in > > ckehoe@chromium.org: Please review changes in > > > > Description: > Add <algorithm> header to audio_directive_list.cc > > The code is using std::{make,push}_heap, but doesn't include the > <algorithm> > header. It > works, because it is pulled as a dependency by something else. I am > currently > doing an update to third_party library that's currently pulling that > header, but > will no longer do after the update, breaking this code. > > BUG=597321 > > Base URL: https://chromium.googlesource.com/chromium/src.git@master > > Affected files (+2, -0 lines): > M components/copresence/handlers/audio/audio_directive_list.cc > > > Index: components/copresence/handlers/audio/audio_directive_list.cc > diff --git a/components/copresence/handlers/audio/audio_directive_list.cc > b/components/copresence/handlers/audio/audio_directive_list.cc > index > fbe623737188580c43989efe16b5edf7de91f205..313f7fa0f8146afd69bae964d9f57eae2e3e4780 > 100644 > --- a/components/copresence/handlers/audio/audio_directive_list.cc > +++ b/components/copresence/handlers/audio/audio_directive_list.cc > @@ -4,6 +4,8 @@ > > #include "components/copresence/handlers/audio/audio_directive_list.h" > > +#include <algorithm> > + > namespace copresence { > > // Public functions. > > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by xyzzyz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832463002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by xyzzyz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832463002/1
Message was sent while issue was closed.
Description was changed from
==========
Add <algorithm> header to audio_directive_list.cc
The code is using std::{make,push}_heap, but doesn't include the <algorithm>
header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
==========
to
==========
Add <algorithm> header to audio_directive_list.cc
The code is using std::{make,push}_heap, but doesn't include the <algorithm>
header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Add <algorithm> header to audio_directive_list.cc
The code is using std::{make,push}_heap, but doesn't include the <algorithm>
header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
==========
to
==========
Add <algorithm> header to audio_directive_list.cc
The code is using std::{make,push}_heap, but doesn't include the <algorithm>
header. It
works, because it is pulled as a dependency by something else. I am currently
doing an update to third_party library that's currently pulling that header, but
will no longer do after the update, breaking this code.
BUG=597321
Committed: https://crrev.com/231c6b3c1a21805754320fe9d72eaf8900abc6eb
Cr-Commit-Position: refs/heads/master@{#382902}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/231c6b3c1a21805754320fe9d72eaf8900abc6eb Cr-Commit-Position: refs/heads/master@{#382902} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
