Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1832453002: Invalidate the LayoutView and all non-composited descendants when doing a full invalidate. (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate the LayoutView and all non-composited descendants when doing a full invalidate. This handles the case when didLayoutWithPendingStylesheets becomes false. In at scenario, it is the layer just below the LayoutView that needs invalidation. BUG=597298 Committed: https://crrev.com/4cb074fdde6959fa8d7e9cc5d787262875740e53 Cr-Commit-Position: refs/heads/master@{#382973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
chrishtr
4 years, 9 months ago (2016-03-23 17:58:37 UTC) #3
Xianzhu
lgtm
4 years, 9 months ago (2016-03-23 18:01:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832453002/1
4 years, 9 months ago (2016-03-23 18:08:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/185485)
4 years, 9 months ago (2016-03-23 19:23:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832453002/1
4 years, 9 months ago (2016-03-23 23:09:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 23:40:24 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 23:41:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cb074fdde6959fa8d7e9cc5d787262875740e53
Cr-Commit-Position: refs/heads/master@{#382973}

Powered by Google App Engine
This is Rietveld 408576698