Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832423003: Fix gn build when nacl is disabled (Closed)

Created:
4 years, 8 months ago by dmazzoni
Modified:
4 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn build when nacl is disabled BUG=none Committed: https://crrev.com/6c7c0cdfb119aece81c6c9f7df8bcd9070f4e557 Cr-Commit-Position: refs/heads/master@{#383610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 8 months ago (2016-03-28 22:05:10 UTC) #2
msw
lgtm
4 years, 8 months ago (2016-03-28 22:06:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832423003/1
4 years, 8 months ago (2016-03-28 22:11:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 23:43:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:46:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6c7c0cdfb119aece81c6c9f7df8bcd9070f4e557
Cr-Commit-Position: refs/heads/master@{#383610}

Powered by Google App Engine
This is Rietveld 408576698