Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1832423002: Revert of [Telemetry] Update the code that detect windows version to use CurrentMajorVersionNumber (Closed)

Created:
4 years, 8 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 8 months ago
Reviewers:
nednguyen, brucedawson
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Update the code that detect windows version to use CurrentMajorVersionNumber (patchset #3 id:40001 of https://codereview.chromium.org/1830253003/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=598359 Original issue's description: > [Telemetry] Update the code that detect windows version to use CurrentMajorVersionNumber > > Since Windows 8, platform.uname()'s third field starts with 6.2, hence to detect > Windows 10, we have to use CurrentMajorVersionNumber from registry. > > BUG=chromium:596640 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/586fde52438f283f7bafb27e4c85ccaee593c4b0 TBR=brucedawson@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:596640 NOTRY=true Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e5abb7bded38f0a9d4c267adf5e8abb115cafca7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M telemetry/telemetry/core/os_version.py View 1 chunk +0 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/win_platform_backend.py View 3 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
oystein (OOO til 10th of July)
Created Revert of [Telemetry] Update the code that detect windows version to use CurrentMajorVersionNumber
4 years, 8 months ago (2016-03-28 17:51:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832423002/1
4 years, 8 months ago (2016-03-28 17:51:31 UTC) #2
brucedawson
On 2016/03/28 17:51:31, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 8 months ago (2016-03-28 18:01:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832423002/1
4 years, 8 months ago (2016-03-28 18:02:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832423002/1
4 years, 8 months ago (2016-03-28 18:06:29 UTC) #8
nednguyen
On 2016/03/28 18:02:16, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 8 months ago (2016-03-28 18:06:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:08:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698