Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 1832413002: DevTools: Address empty query parameters being displayed fugly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
index 1cd8eadd508411fbc30eae829d55b32ea68cdd6d..83ad41075e7ed40d78cb6622b4c0ea33885d6e0f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -859,10 +859,15 @@ WebInspector.NetworkRequest.prototype = {
function parseNameValue(pair)
{
var position = pair.indexOf("=");
- if (position === -1)
+ if (position === -1) {
+ if (pair === "") {
+ return {name: "(empty)", value: "(empty)"};
caseq 2016/04/06 18:36:43 I'd rather say we could skip these, but if the con
+ }
return {name: pair, value: ""};
- else
+ }
+ else {
return {name: pair.substring(0, position), value: pair.substring(position + 1)};
+ }
}
return queryString.split("&").map(parseNameValue);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698