rebaseline.py: use specified configs/tests as a FILTER over actually-run tests

rebaseline.py: use specified configs/tests as a FILTER over actually-run tests

Now that we have the actual-results.json file for every bot type, we know
the full set of tests that actual results are available for. If configs and/or
tests are specified, just use those as FILTERS over the actually available
results.

R=senorblanco@chromium.org

Committed: https://code.google.com/p/skia/source/detail?r=9956

[epoger, 2013-07-09 20:08:40]

Ready for review at patchset 2.

In addition to the general utility of this change, it should make the output and
error behavior of rebaseline.py easier to follow, thus helping with
https://code.google.com/p/skia/issues/detail?id=1403 ('Unable to use the
rebaseline.py script')

https://codereview.chromium.org/18324018/diff/1/tools/tests/rebaseline/output...
File tools/tests/rebaseline/output/all/output-expected/command_line (left):

https://codereview.chromium.org/18324018/diff/1/tools/tests/rebaseline/output...
tools/tests/rebaseline/output/all/output-expected/command_line:1: python
tools/rebaseline.py --dry-run --actuals-base-url file:nonexistent-path --tests
test1 test2
I had to delete this old test that ran without an actual-results.json file... we
need that file now.

[Stephen White, 2013-07-10 14:58:01]

LGTM, with a fix to the help line

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline.py
File tools/rebaseline.py (right):

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline.py#newcod...
tools/rebaseline.py:243: '"--tests aaclip bigmatrix", as a filter over the full
' +
It looks like this sentence got truncated.

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline_imagefile...
File tools/rebaseline_imagefiles.py (left):

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline_imagefile...
tools/rebaseline_imagefiles.py:128: # Download a single actual result from
skia-autogen, returning True if it
So is this basically the death of skia-autogen? Not clear from the patch desc,
but if so, "ding, dong, the witch is dead!" :)

[epoger, 2013-07-10 15:24:52]

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline.py
File tools/rebaseline.py (right):

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline.py#newcod...
tools/rebaseline.py:243: '"--tests aaclip bigmatrix", as a filter over the full
' +
On 2013/07/10 14:58:01, Stephen White wrote:
> It looks like this sentence got truncated.

Done.

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline_imagefile...
File tools/rebaseline_imagefiles.py (left):

https://codereview.chromium.org/18324018/diff/1001/tools/rebaseline_imagefile...
tools/rebaseline_imagefiles.py:128: # Download a single actual result from
skia-autogen, returning True if it
On 2013/07/10 14:58:01, Stephen White wrote:
> So is this basically the death of skia-autogen? Not clear from the patch desc,
> but if so, "ding, dong, the witch is dead!" :)

Ding dong indeed... skia-autogen still exists (see
https://code.google.com/p/skia-autogen/source/browse ), but it now contains just
the actual-results.json files, and NO image files.  All of the image files are
now stored in Google Storage, indexed by hash digest.

[epoger, 2013-07-10 15:27:21]

Committed patchset #4 manually as r9956 (presubmit successful).