Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1832393003: MD Settings: small visual tweak to policy indicators while we think harder about them (Closed)

Created:
4 years, 8 months ago by Dan Beam
Modified:
4 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: small visual tweak to policy indicators while we think harder about them R=stevenjb@chromium.org BUG=598515 Committed: https://crrev.com/2e2612c145541b8de7842db1f3cab2fb793a9909 Cr-Commit-Position: refs/heads/master@{#383778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
note: "this is dumb, wait for bettes" is a perfectly valid response to this as ...
4 years, 8 months ago (2016-03-29 03:12:12 UTC) #1
stevenjb
This seems fine; better is better. LGTM.
4 years, 8 months ago (2016-03-29 16:53:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832393003/1
4 years, 8 months ago (2016-03-29 17:48:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 18:39:40 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 18:42:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e2612c145541b8de7842db1f3cab2fb793a9909
Cr-Commit-Position: refs/heads/master@{#383778}

Powered by Google App Engine
This is Rietveld 408576698