Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1832393002: Add more features to the summary linker. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more features to the summary linker. We now detect constant cycles involving: - Named constructors. - Generic classes. (Note: we don't track the type arguments of generic classes yet, because that's unnecessary for detecting constant constructor cycles). - References to top level constant variables and constant fields. - Final fields in constant classes. - Implicit calls to "super". Also, we properly handle constants that refer to fields of an enum class. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fbeff9c9041f581c7de9c25246d1f001fc7fb983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -50 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 22 chunks +215 lines, -39 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +164 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-03-28 17:12:43 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-28 17:33:08 UTC) #3
Paul Berry
4 years, 8 months ago (2016-03-28 17:39:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fbeff9c9041f581c7de9c25246d1f001fc7fb983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698