Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832343003: Intrinsify some double operations, helps in AOT (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -6 lines) Patch
M runtime/vm/intrinsifier.cc View 1 1 chunk +61 lines, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
4 years, 8 months ago (2016-03-28 19:35:18 UTC) #2
Florian Schneider
Lgtm. https://codereview.chromium.org/1832343003/diff/1/runtime/vm/intrinsifier.cc File runtime/vm/intrinsifier.cc (right): https://codereview.chromium.org/1832343003/diff/1/runtime/vm/intrinsifier.cc#newcode8 runtime/vm/intrinsifier.cc:8: #include "vm/cpu.h" Why is this include needed?
4 years, 8 months ago (2016-03-28 19:42:54 UTC) #3
Cutch
https://codereview.chromium.org/1832343003/diff/1/runtime/vm/intrinsifier.cc File runtime/vm/intrinsifier.cc (right): https://codereview.chromium.org/1832343003/diff/1/runtime/vm/intrinsifier.cc#newcode8 runtime/vm/intrinsifier.cc:8: #include "vm/cpu.h" On 2016/03/28 19:42:54, Florian Schneider wrote: > ...
4 years, 8 months ago (2016-03-28 20:08:46 UTC) #4
Cutch
4 years, 8 months ago (2016-03-28 20:09:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
24230689dfd90f1fd12793613c14ae5dfccaefab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698