Introduce BackspaceStateMachine

Introduce BackspaceStateMachine

BackspaceStateMachine is for deleting complex unicode sequence by
backspace key event.  This CL only introduces surrogate pair handling.
Note that BackspaceStateMachine will be compiled, linked and tested but
not yet used in production with this CL.

BUG=594920
R=yosin

Committed: https://crrev.com/112c661e776be3a9a3ba04c2de484d0687630e83
Cr-Commit-Position: refs/heads/master@{#383685}

[Seigo Nonaka, 2016-03-28 07:51:51]

Hi Yosi-san,
Could you kindly take a look?

Thank you.

[Seigo Nonaka, 2016-03-28 07:52:57]

nona@chromium.org changed reviewers:
+ yosin@chromium.org
- yosin@google.com

[Seigo Nonaka, 2016-03-28 07:52:58]

I'm sorry I added wrong account.

Yosi-san could you kindly take a look?

Thank you.

[yosin_UTC9, 2016-03-28 09:33:51]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-03-28 09:33:52]

lgtm

+tkent@ for core/ changes

Note: This patch is split from crrev.com/1824143003: [All-In-One] Introduce
BackspaceStateMachine

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/DEPS (right):

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/DEPS:11:
"+third_party/icu/source/common/unicode",
MEMO: This change is also in crrev.com/1833413002

[tkent, 2016-03-29 00:06:46]

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/BackspaceStateMachine.cpp (right):

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/BackspaceStateMachine.cpp:7: #include
"third_party/icu/source/common/unicode/utf16.h"
Does wtf/unicode/Unicode.h work?

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/BackspaceStateMachine.h (right):

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/BackspaceStateMachine.h:22: bool
updateState(uint16_t codeUnit);
uint16_t -> UChar

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/BackspaceStateMachine.h:36: uint16_t
m_trailSurrogate = 0;
uint16_t -> UChar

[Seigo Nonaka, 2016-03-29 04:29:05]

Thank you for your review.
By using Unicode.h I can avoid adding additional DEPS entry.

Could you take an another look?

Thank you.

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/DEPS (right):

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/DEPS:11:
"+third_party/icu/source/common/unicode",
On 2016/03/28 09:33:52, Yosi_UTC9 wrote:
> MEMO: This change is also in crrev.com/1833413002

Done.

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/BackspaceStateMachine.cpp (right):

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/BackspaceStateMachine.cpp:7: #include
"third_party/icu/source/common/unicode/utf16.h"
On 2016/03/29 00:06:46, tkent wrote:
> Does wtf/unicode/Unicode.h work?

Yes, it works.

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/BackspaceStateMachine.h (right):

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/BackspaceStateMachine.h:22: bool
updateState(uint16_t codeUnit);
On 2016/03/29 00:06:46, tkent wrote:
> uint16_t -> UChar

Done.

https://codereview.chromium.org/1832343002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/BackspaceStateMachine.h:36: uint16_t
m_trailSurrogate = 0;
On 2016/03/29 00:06:46, tkent wrote:
> uint16_t -> UChar

Done.

[tkent, 2016-03-29 04:59:16]

lgtm

[Seigo Nonaka, 2016-03-29 06:00:45]

The CQ bit was checked by nona@chromium.org

[Seigo Nonaka, 2016-03-29 06:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1832343002/#ps40001
(title: "Remove unnecessary includes.")

[commit-bot: I haz the power, 2016-03-29 06:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832343002/40001

[commit-bot: I haz the power, 2016-03-29 07:19:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 07:21:41]

Description was changed from

==========
Introduce BackspaceStateMachine

BackspaceStateMachine is for deleting complex unicode sequence by
backspace key event.  This CL only introduces surrogate pair handling.
Note that BackspaceStateMachine will be compiled, linked and tested but
not yet used in production with this CL.

BUG=594920
R=yosin
==========

to

==========
Introduce BackspaceStateMachine

BackspaceStateMachine is for deleting complex unicode sequence by
backspace key event.  This CL only introduces surrogate pair handling.
Note that BackspaceStateMachine will be compiled, linked and tested but
not yet used in production with this CL.

BUG=594920
R=yosin

Committed: https://crrev.com/112c661e776be3a9a3ba04c2de484d0687630e83
Cr-Commit-Position: refs/heads/master@{#383685}
==========

[commit-bot: I haz the power, 2016-03-29 07:21:42]

Patchset 3 (id:??) landed as
https://crrev.com/112c661e776be3a9a3ba04c2de484d0687630e83
Cr-Commit-Position: refs/heads/master@{#383685}