Updates the test runner script exit codes

build/android/pylib/browsertests/dispatch.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dispatches content_browsertests."""
 
 import logging
 import os
 import sys
 
 from pylib import android_commands
 from pylib import cmd_helper
 from pylib import constants
 from pylib import ports
 from pylib.base import shard
 from pylib.gtest import dispatch as gtest_dispatch
 from pylib.gtest import test_runner
 from pylib.utils import report_results
 
 sys.path.insert(0,
                 os.path.join(constants.DIR_SOURCE_ROOT, 'build', 'util', 'lib'))
 from common import unittest_util
 
 
 def Dispatch(options):

[frankf, 2013/07/03 21:26:37]

Future TODO: There's a lot of duplicaiton in dispatch modules. Currently they
all:

1. Get list of devices
2. Reset test server allocation
3. Create runners and shard tests between them
4. report results (java tests now do this in test_runner.py)

The common code should be pulled out into test_runner.py

[gkanwar, 2013/07/03 23:15:18]

Agreed. Should I file a bug for this perhaps?

-  """Dispatches all content_browsertests."""
+  """Dispatches all content_browsertests.
+
+  Args:
+    options: optparse.Options object containing command-line options
+  Returns:
+    base_test_result.TestRunResults object with the results of running the tests
+  Raises:
+    Exception: Failed to reset the test server port.
+  """
 
   attached_devices = []
   if options.test_device:
     attached_devices = [options.test_device]
   else:
     attached_devices = android_commands.GetAttachedDevices()
 
   if not attached_devices:
     logging.critical('A device must be attached and online.')
     return 1
@@ skipping 44 matching lines @@
                                         test_timeout=None,
                                         num_retries=options.num_retries)
   report_results.LogFull(
       results=test_results,
       test_type='Unit test',
       test_package=constants.BROWSERTEST_SUITE_NAME,
       build_type=options.build_type,
       flakiness_server=options.flakiness_dashboard_server)
   report_results.PrintAnnotation(test_results)
 
-  return len(test_results.GetNotPass())
+  return test_results
 
 
 def _FilterTests(all_enabled_tests):
   """Filters out tests and fixtures starting with PRE_ and MANUAL_."""
   return [t for t in all_enabled_tests if _ShouldRunOnBot(t)]
 
 
 def _ShouldRunOnBot(test):
   fixture, case = test.split('.', 1)
   if _StartsWith(fixture, case, 'PRE_'):
     return False
   if _StartsWith(fixture, case, 'MANUAL_'):
     return False
   return True
 
 
 def _StartsWith(a, b, prefix):
   return a.startswith(prefix) or b.startswith(prefix)