Issue 18323018:
Linking AvailabilityFinder with APIDataSource and intro-table templates. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set:
Created 7 years, 6 months ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
epeterson
2013/07/03 19:05:02
Here's an interesting point with checking availabi
Here's an interesting point with checking availability in versions 18 and 19:
chrome.storage is listed as 20 in its current hardcoded intro-table.
Using AvailabilityFinder, chrome.storage's availability comes out to be 19. This
is because the _features.json files don't have 'channel' information in version
19 and don't exist in version 18.
So, file system existence is used, and storage.json exists in version 19, but
not in 18.
It doesn't seem like there's really a good reference point to use for versions
18 and 19.
not at google - send to devlin
2013/07/03 19:54:56
Ah right. How many does this affect?
On 2013/07/03 19:05:02, epeterson wrote:
> Here's an interesting point with checking availability in versions 18 and 19:
>
> chrome.storage is listed as 20 in its current hardcoded intro-table.
>
> Using AvailabilityFinder, chrome.storage's availability comes out to be 19.
This
> is because the _features.json files don't have 'channel' information in
version
> 19 and don't exist in version 18.
>
> So, file system existence is used, and storage.json exists in version 19, but
> not in 18.
>
> It doesn't seem like there's really a good reference point to use for versions
> 18 and 19.
Ah right. How many does this affect?
epeterson
2013/07/09 20:51:18
Other APIs like browsingData, topSites, privacy, a
On 2013/07/03 19:54:56, kalman wrote:
> On 2013/07/03 19:05:02, epeterson wrote:
> > Here's an interesting point with checking availability in versions 18 and
19:
> >
> > chrome.storage is listed as 20 in its current hardcoded intro-table.
> >
> > Using AvailabilityFinder, chrome.storage's availability comes out to be 19.
> This
> > is because the _features.json files don't have 'channel' information in
> version
> > 19 and don't exist in version 18.
> >
> > So, file system existence is used, and storage.json exists in version 19,
but
> > not in 18.
> >
> > It doesn't seem like there's really a good reference point to use for
versions
> > 18 and 19.
>
> Ah right. How many does this affect?
Other APIs like browsingData, topSites, privacy, and debugger, fall into the
version 18/19 availability, but comparing these with information listed on the
whats_new page, they appear to have the correct generated availability.
Looking at the pageCapture API, the whats_new page lists it as stable in 18, but
17 is the generated availability, since it shows up in extension_api.json in
version 17 (and I thought that if it wasn't tagged as 'experimental' back in the
extension_api.json days, then it was 'stable').
input.ime is listed as available at 21 in the whats_new page.
input.ime is experimental in version 17 in extension_api.json, and has a .json
file present up until then, so its given an availability of 18. It was not
represented in _manifest or _permission_features.json.
Not sure how to get something accurate for cases like this, since there's no
hint as to what channels these APIs are available on before version 20, and
there's not a concrete method to use pre-version 20. This is kind of a letdown.
I apologize.
epeterson
2013/07/09 20:51:18
For reference, here's a list of the API availabili
> Not sure how to get something accurate for cases like this, since there's no
> hint as to what channels these APIs are available on before version 20, and
> there's not a concrete method to use pre-version 20. This is kind of a
letdown.
> I apologize.
Heh, not at all, it was pretty undisciplined back then. Perhaps these
restrictions were implemented procedurally or something.
For things as far back s 18/19/20 I think nobody will notice if they're a couple
of versions off, though we should try our best, and yeah if you're not sure then
just be conservative and use the most recent version.
Issue 18323018: Linking AvailabilityFinder with APIDataSource and intro-table templates.
(Closed)
Created 7 years, 6 months ago by epeterson
Modified 7 years, 5 months ago
Reviewers: not at google - send to devlin, evan.peterson.ep_gmail.com
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 122
Chromium Code Reviews
Issue 18323018:
Linking AvailabilityFinder with APIDataSource and intro-table templates. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master