chrome/common/extensions/docs/templates/private/intro_table.html - Issue 18323018: Linking AvailabilityFinder with APIDataSource and intro-table templates.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/intro_table.html

Issue 18323018: Linking AvailabilityFinder with APIDataSource and intro-table templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: HostFileSystemCreator, Intro Table data structure changes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/templates/json/intro_tables.json ('K') | « chrome/common/extensions/docs/templates/json/intro_tables.json ('k') | chrome/common/extensions/docs/templates/private/standard_apps_api.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <table class="intro">

	2 {{#api.intro_list}}

	3 <tr>

	4 <td>

	5 <strong>{{title}}:</strong>

	6 </td>

	7 <td>

	8 {{#content}}

	9 {{?link}}

	10 <a href="{{link}}">{{text}}</a>

	11 {{:link}}

	12 {{?perm}}

	13 <code>"{{perm}}"{{?text}}: [{{text}}]{{/text}}</code>

	14 {{:perm}}

	15 {{?text}}

	16 {{{text}}}
	not at google - send to devlin 2013/07/09 23:11:55 so regarding your thing about not needing {{{ }}} so regarding your thing about not needing {{{ }}} - yes, it would be great not to need it and to encode any styling into the model. I think I made some comments earlier which allude to you hopefully not needing the "perm" special case at all. can this look like: {{#content}} {{?link}}<a href="{{link}}">{{/}} {{?class}}<span class="{{class}}">{{/}} {{text}} {{?class}}</span>{{/}} {{?link}}</a>{{/}} {{/content}} it would be much simpler... though maybe it would look better expanded, dunno. {{#content}} {{?link}} <a href="{{link}}"> {{/link}} {{?class}} <span class="{{class}}"> {{/class}} {{text}} {{?class}} </span> {{/class}} {{?link}} </a> {{/link}} {{/content}} maybe not. epeterson 2013/07/16 00:28:23 The "perm" special case is gone. I think the {{{ Show quoted text On 2013/07/09 23:11:55, kalman wrote: > so regarding your thing about not needing {{{ }}} - yes, it would be great not > to need it and to encode any styling into the model. > > I think I made some comments earlier which allude to you hopefully not needing > the "perm" special case at all. > > can this look like: > > {{#content}} > {{?link}}<a href="{{link}}">{{/}} > {{?class}}<span class="{{class}}">{{/}} > {{text}} > {{?class}}</span>{{/}} > {{?link}}</a>{{/}} > {{/content}} > > it would be much simpler... though maybe it would look better expanded, dunno. > > {{#content}} > {{?link}} > <a href="{{link}}"> > {{/link}} > {{?class}} > <span class="{{class}}"> > {{/class}} > {{text}} > {{?class}} > </span> > {{/class}} > {{?link}} > </a> > {{/link}} > {{/content}} > > maybe not. The "perm" special case is gone. I think the {{{ }}}'s are going to be hard to avoid, at least with this model. Currently, each node represents a piece of text wrapped in a span or link. We'd need to be able to put text both before and after a link or span, and we'd need to be able to do it multiple times for one block of text, as with an API description, where there could be multiple spans or links present.
	17 {{/text}}

	18 {{/perm}}

	19 {{/link}}

	20 <br>

	21 {{/content}}

	22 </td>

	23 </tr>

	24 {{/api.intro_list}}

	25 </table>

OLD	NEW