Linking AvailabilityFinder with APIDataSource and intro-table templates.

chrome/common/extensions/docs/server2/cron_servlet.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import time
 import traceback
 
 from app_yaml_helper import AppYamlHelper
 from appengine_wrappers import (
     GetAppVersion, DeadlineExceededError, IsDevServer, logservice)
 from branch_utility import BranchUtility
 from caching_file_system import CachingFileSystem
 from compiled_file_system import CompiledFileSystem
 from empty_dir_file_system import EmptyDirFileSystem
 from github_file_system import GithubFileSystem
+from host_file_system_creator import HostFileSystemCreator
 from object_store_creator import ObjectStoreCreator
 from render_servlet import RenderServlet
 from server_instance import ServerInstance
 from servlet import Servlet, Request, Response
 from subversion_file_system import SubversionFileSystem
 import svn_constants
 from third_party.json_schema_compiler.memoize import memoize
 
 class _SingletonRenderServletDelegate(RenderServlet.Delegate):
   def __init__(self, server_instance):
     self._server_instance = server_instance
 
   def CreateServerInstanceForChannel(self, channel):
     return self._server_instance
 
 class CronServlet(Servlet):
   '''Servlet which runs a cron job.
   '''
   def __init__(self, request, delegate_for_test=None):
     Servlet.__init__(self, request)
     self._channel = request.path.strip('/')
     self._delegate = delegate_for_test or CronServlet.Delegate()
 
   class Delegate(object):
     '''CronServlet's runtime dependencies. Override for testing.
     '''
     def CreateBranchUtility(self, object_store_creator):
       return BranchUtility.Create(object_store_creator)
 
+    def CreateHostFileSystem(self, branch):
+      return SubversionFileSystem.Create(branch)
+
     def CreateHostFileSystemForBranchAndRevision(self, branch, revision):
       return SubversionFileSystem.Create(branch, revision=revision)
 
     def CreateAppSamplesFileSystem(self, object_store_creator):
       # TODO(kalman): CachingFileSystem wrapper for GithubFileSystem, but it's
       # not supported yet (see comment there).
       return (EmptyDirFileSystem() if IsDevServer() else
               GithubFileSystem.Create(object_store_creator))
 
     def GetAppVersion(self):
@@ skipping 125 matching lines @@
     channel = self._channel
     delegate = self._delegate
 
     server_instance_at_head = self._CreateServerInstance(channel, None)
 
     get_branch_for_channel = self._GetBranchForChannel
     class AppYamlHelperDelegate(AppYamlHelper.Delegate):
       def GetHostFileSystemForRevision(self, revision):
         return delegate.CreateHostFileSystemForBranchAndRevision(
             get_branch_for_channel(channel),
-            revision)
+            revision=revision)
 
     app_yaml_handler = AppYamlHelper(
         svn_constants.APP_YAML_PATH,
         server_instance_at_head.host_file_system,
         AppYamlHelperDelegate(),
         server_instance_at_head.object_store_creator)
 
     if app_yaml_handler.IsUpToDate(delegate.GetAppVersion()):
       # TODO(kalman): return a new ServerInstance at an explicit revision in
       # case the HEAD version changes underneath us.
@@ skipping 12 matching lines @@
   def _CreateObjectStoreCreator(self, channel):
     return ObjectStoreCreator(channel, start_empty=True)
 
   def _GetBranchForChannel(self, channel):
     object_store_creator = self._CreateObjectStoreCreator(channel)
     return (self._delegate.CreateBranchUtility(object_store_creator)
         .GetChannelInfo(channel).branch)
 
   def _CreateServerInstance(self, channel, revision):
     object_store_creator = self._CreateObjectStoreCreator(channel)
+    branch_utility = self._delegate.CreateBranchUtility(object_store_creator)
+    host_file_system_creator = HostFileSystemCreator(
+        branch_utility,
+        self._delegate.CreateHostFileSystem,
+        object_store_creator,
+        offline=False)

[not at google - send to devlin, 2013/07/09 23:11:55]

False should be the default here so you can leave it out

[epeterson, 2013/07/16 00:28:23]

Done.

+    # Using HostFileSystemCreator

[not at google - send to devlin, 2013/07/09 23:11:55]

yep let's use it

[epeterson, 2013/07/16 00:28:23]

Done.

+    '''
+    host_file_system = host_file_system_creator.CreateAtBranch(
+        branch_utility.GetChannelInfo(channel).branch)
+    '''
+    # CreateHostFileSystemForBranchAndRevision
     host_file_system = CachingFileSystem(
         self._delegate.CreateHostFileSystemForBranchAndRevision(
             self._GetBranchForChannel(channel),
             revision),
         object_store_creator)
+    # Using only CreateHostFileSystem
+    '''
+    host_file_system = CachingFileSystem(
+        self._delegate.CreateHostFileSystem(
+            self._GetBranchForChannel(channel),
+            revision=revision),
+        object_store_creator)
+    '''
     app_samples_file_system = self._delegate.CreateAppSamplesFileSystem(
         object_store_creator)
     compiled_host_fs_factory = CompiledFileSystem.Factory(
         host_file_system,
         object_store_creator)
     return ServerInstance(channel,
                           object_store_creator,
                           host_file_system,
                           app_samples_file_system,
                           '' if channel == 'stable' else '/%s' % channel,
-                          compiled_host_fs_factory)
+                          compiled_host_fs_factory,
+                          branch_utility,
+                          host_file_system_creator)