chrome/common/extensions/docs/templates/private/intro_table.html - Issue 18323018: Linking AvailabilityFinder with APIDataSource and intro-table templates.

Side by Side Diff: chrome/common/extensions/docs/templates/private/intro_table.html

Issue 18323018: Linking AvailabilityFinder with APIDataSource and intro-table templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/templates/json/intro_tables.json ('K') | « chrome/common/extensions/docs/templates/json/intro_tables.json ('k') | chrome/common/extensions/docs/templates/private/standard_apps_api.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <table class="intro">

	2 <tr>

	3 <th scope="col"></th>

	4 <th scope="col"></th>

	5 </tr>
	not at google - send to devlin 2013/07/03 19:54:56 what is this empty row for..? what is this empty row for..? epeterson 2013/07/09 20:51:18 It was in the hardcoded intro tables, so I kind of Show quoted text On 2013/07/03 19:54:56, kalman wrote: > what is this empty row for..? It was in the hardcoded intro tables, so I kind of just rolled with it. But it looks like that scope attribute does nothing for browsers but is used for screen readers? I'm just going to get rid of it for now..
	6 <tr>

	7 <td>

	8 <strong>Description:</strong>

	9 </td>

	10 <td>

	11 {{?api.description}}

	12 {{{api.description}}}

	13 {{:}}

	14 The <code>chrome.{{api.name}}</code> API
	not at google - send to devlin 2013/07/03 19:54:56 end in fullstop end in fullstop epeterson 2013/07/09 20:51:18 Done. Show quoted text On 2013/07/03 19:54:56, kalman wrote: > end in fullstop Done.
	15 {{/api.description}}

	16 </td>

	17 </tr>

	18 <tr>

	19 <td>

	20 <strong>Availability:</strong>

	21 </td>

	22 <td>

	23 {{?api.availability}}

	24 Chrome {{api.availability}}

	25 {{:api.availability}}

	26 {{?api.experimental}}

	27 Experimental only (see <a href="experimental.html#using">How to use ex perimental APIs</a>)

	28 {{:api.experimental}}

	29 Available.

	30 {{/api.experimental}}
	not at google - send to devlin 2013/07/03 19:54:56 We need a richer data model here. Probably from AP We need a richer data model here. Probably from API data source we'll set - is_experimental - is_dev - is_beta - stable_version (only one of those). There are already templates that exist for showing the dev/beta warnings, maybe the experimental one, and then you'll need to add the "stable since Chrome X" thing in here. epeterson 2013/07/09 20:51:18 This comment may have been outdated by your most r Show quoted text On 2013/07/03 19:54:56, kalman wrote: > We need a richer data model here. Probably from API data source we'll set > - is_experimental > - is_dev > - is_beta > - stable_version > > (only one of those). > > There are already templates that exist for showing the dev/beta warnings, maybe > the experimental one, and then you'll need to add the "stable since Chrome X" > thing in here. This comment may have been outdated by your most recent request to change the data model.
	31 {{/api.availability}}

	32 </td>

	33 </tr>

	34 <tr>

	35 <td>

	36 <strong>Permissions:</strong>

	37 </td>

	38 <td>

	39 {{?api.api_permissions}}

	40 {{#api.api_permissions}}

	41 {{?permission}}<code>{{permission}}</code>{{/permission}}

	42 {{?extra}}{{{extra}}}{{/extra}}

	43 <br>
	not at google - send to devlin 2013/07/03 19:54:56 why the <br>? why the <br>? epeterson 2013/07/09 20:51:18 There's the possibility of permissions line-wrappi Show quoted text On 2013/07/03 19:54:56, kalman wrote: > why the <br>? There's the possibility of permissions line-wrapping, like here: http://developer.chrome.com/trunk/apps/mediaGalleries.html <br>'s prevent this, at the expense of shorter permissions not being able to fit all on one line, I suppose. Doesn't having each permission on a separate line more accurately model how permissions look when declared in a manifest, as well? Of course, if permissions should look like they do in manifest files, then they need double-quotes (which is what they have in the hardcoded tables)...so I added those just now. not at google - send to devlin 2013/07/09 23:11:55 sgtm Show quoted text On 2013/07/09 20:51:18, epeterson wrote: > On 2013/07/03 19:54:56, kalman wrote: > > why the <br>? > > There's the possibility of permissions line-wrapping, like here: > http://developer.chrome.com/trunk/apps/mediaGalleries.html > > <br>'s prevent this, at the expense of shorter permissions not being able to fit > all on one line, I suppose. > Doesn't having each permission on a separate line more accurately model how > permissions look when declared in a manifest, as well? > > Of course, if permissions should look like they do in manifest files, then they > need double-quotes (which is what they have in the hardcoded tables)...so I > added those just now. sgtm
	44 {{/api.api_permissions}}

	45 {{:api.api_permissions}}

	46 None

	47 {{/api.api_permissions}}

	48 </td>

	49 </tr>

	50 {{?api.learn_more}}

	51 <tr>

	52 <td>

	53 <strong>Learn more:</strong>

	54 </td>

	55 <td>

	56 {{#api.learn_more}}

	57 {{?prefix}}{{prefix}}{{/prefix}}

	58 <a href='{{href}}'>{{content}}</a>

	59 {{?suffix}}{{suffix}}{{/suffix}}

	60 <br>

	61 {{/api.learn_more}}

	62 </td>

	63 </tr>

	64 {{/}}

	65 </table>

OLD	NEW