Linking AvailabilityFinder with APIDataSource and intro-table templates.

chrome/common/extensions/docs/server2/cron_servlet.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import time
 import traceback
 
 from app_yaml_helper import AppYamlHelper
 from appengine_wrappers import (
@@ skipping 28 matching lines @@
 
   class Delegate(object):
     '''CronServlet's runtime dependencies. Override for testing.
     '''
     def CreateBranchUtility(self, object_store_creator):
       return BranchUtility.Create(object_store_creator)
 
     def CreateHostFileSystemForBranchAndRevision(self, branch, revision):
       return SubversionFileSystem.Create(branch, revision=revision)
 
+    def CreateFileSystemForBranch(self, branch):
+      return SubversionFileSystem.Create(branch)

[not at google - send to devlin, 2013/07/03 19:54:56]

maybe we should just rename CreateHostFIleSystemForBranchAndRevision to
CreateHostFileSystem(...) and make revision optional.

[epeterson, 2013/07/09 20:51:18]

The cron_servlet_test likes to count up how many file_systems it's been created
along with stat and read counts, so only having CreateHostFileSystem throws off
those tests.

[not at google - send to devlin, 2013/07/09 23:11:55]

ah right. and this does actually break the test? I can see how it would.

maybe we can add a primary_for_test flag to this method and cron_servlet_test
can use that flag to determine whether it should add to its list thing.

+
     def CreateAppSamplesFileSystem(self, object_store_creator):
       # TODO(kalman): CachingFileSystem wrapper for GithubFileSystem, but it's
       # not supported yet (see comment there).
       return (EmptyDirFileSystem() if IsDevServer() else
               GithubFileSystem.Create(object_store_creator))
 
     def GetAppVersion(self):
       return GetAppVersion()
 
   def Get(self):
@@ skipping 165 matching lines @@
     host_file_system = CachingFileSystem(
         self._delegate.CreateHostFileSystemForBranchAndRevision(
             self._GetBranchForChannel(channel),
             revision),
         object_store_creator)
     app_samples_file_system = self._delegate.CreateAppSamplesFileSystem(
         object_store_creator)
     compiled_host_fs_factory = CompiledFileSystem.Factory(
         host_file_system,
         object_store_creator)
+    branch_utility = self._delegate.CreateBranchUtility(object_store_creator)
+    def create_file_system(version):
+      return CachingFileSystem(
+          self._delegate.CreateFileSystemForBranch(
+              branch_utility.GetBranchForVersion(version)),
+          object_store_creator)

[not at google - send to devlin, 2013/07/03 19:54:56]

let's introduce a class like HostFileSystemCreator (vaguely analogous to
ObjectStoreCreator) with a method like CreateAtVersion.

then inject that into ServerInstance rather than this magic function.

I think there are other places that we could use such a class, but, worry about
that later.

[epeterson, 2013/07/09 20:51:18]

Done.

     return ServerInstance(channel,
                           object_store_creator,
                           host_file_system,
                           app_samples_file_system,
                           '' if channel == 'stable' else '/%s' % channel,
-                          compiled_host_fs_factory)
+                          compiled_host_fs_factory,
+                          branch_utility,
+                          create_file_system)