Linking AvailabilityFinder with APIDataSource and intro-table templates.

chrome/common/extensions/docs/server2/availability_finder.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import os
 
 from branch_utility import BranchUtility
 from compiled_file_system import CompiledFileSystem
 from file_system import FileNotFoundError
@@ skipping 143 matching lines @@
         return version + 1
       available = False
       features_fs, names_fs = self._CreateFeaturesAndNamesFileSystems(version)
       if version >= 28:
         # The _api_features.json file first appears in version 28 and should be
         # the most reliable for finding API availabilities, so it gets checked
         # first. The _permission_features.json and _manifest_features.json files
         # are present in Chrome 20 and onwards. Fall back to a check for file
         # system existence if the API is not stable in any of the _features.json
         # files.
-        available = _GetChannelFromApiFeatures(api_name, features_fs) == _STABLE
+        available = _GetChannelFromApiFeatures(api_name, features_fs)
       if version >= 20:
         # Check other _features.json files/file existence if the API wasn't
         # found in _api_features.json, or if _api_features.json wasn't present.
         available = available or (
-            _GetChannelFromPermissionFeatures(api_name, features_fs) == _STABLE
-            or _GetChannelFromManifestFeatures(api_name, features_fs) == _STABLE
-            or _ExistsInFileSystem(api_name, names_fs))
+            _GetChannelFromPermissionFeatures(api_name, features_fs)
+            or _GetChannelFromManifestFeatures(api_name, features_fs))
+        if available is None:
+          available = _ExistsInFileSystem(api_name, names_fs)
+        else:
+          available = available == _STABLE

[epeterson, 2013/07/03 19:05:02]

There was a bug here: file system existence was checked even when an API was
listed as being beta/dev/trunk in one of the features files. 

The AvailabilityFinder test didn't catch this because I didn't put mock
.json/.idl files into the test file system where the APIs were in the mock
_features.json files. But I've added to the test file system so that this case
is tested now.

[not at google - send to devlin, 2013/07/03 19:54:56]

Cool, nice catch.

But I don't like the way that available is sometime a bool and other times a
channel. Could you introduce another variable like available_channel or
something?

[epeterson, 2013/07/09 20:51:18]

Done. Also updated 'channel' to 'available_channel' in the
_GetAvailableChannelForVersion method to be consistent.

       elif version >= 18:
         # These versions are a little troublesome. Version 19 has
         # _permission_features.json, but it lacks 'channel' information.
         # Version 18 lacks all of the _features.json files. For now, we're using
         # a simple check for filesystem existence here.
         available = _ExistsInFileSystem(api_name, names_fs)
       elif version >= 5:
         # Versions 17 and down to 5 have an extension_api.json file which
         # contains namespaces for each API that was available at the time. We
         # can use this file to check for API existence.
@@ skipping 56 matching lines @@
 
     # If the API is in stable, find the chrome version in which it became
     # stable.
     if availability.channel == _STABLE:
       availability.version = self._FindEarliestStableAvailability(
           api_name,
           availability.version)
 
     self._object_store.Set(api_name, availability)
     return availability