Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832253002: Settings People Revamp: Address CSS wrongdoings. (Closed)

Created:
4 years, 9 months ago by tommycli
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Address CSS wrongdoings. This also fixes the subheader of all subpages. BUG=597868 Committed: https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0 Cr-Commit-Position: refs/heads/master@{#383423}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M chrome/browser/resources/settings/people_page/manage_profile.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.css View 1 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 1 chunk +20 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subheader.html View 1 2 3 1 chunk +16 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
tommycli
dschuyler: PTAL, thanks!
4 years, 9 months ago (2016-03-25 22:23:28 UTC) #2
dschuyler
https://codereview.chromium.org/1832253002/diff/1/chrome/browser/resources/settings/people_page/people_page.css File chrome/browser/resources/settings/people_page/people_page.css (right): https://codereview.chromium.org/1832253002/diff/1/chrome/browser/resources/settings/people_page/people_page.css#newcode22 chrome/browser/resources/settings/people_page/people_page.css:22: </if> Please move these css settings into people_page.html and ...
4 years, 9 months ago (2016-03-25 22:33:15 UTC) #3
dschuyler
4 years, 9 months ago (2016-03-25 22:33:20 UTC) #4
tommycli
dschuyler: thanks I rejiggered the subheader page to match the mocks Alan sent me. I'm ...
4 years, 9 months ago (2016-03-25 23:02:40 UTC) #5
tommycli
dschuyler: per offline discussion changed most of subheader back.
4 years, 9 months ago (2016-03-25 23:33:45 UTC) #6
dschuyler
lgtm
4 years, 9 months ago (2016-03-25 23:41:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832253002/60001
4 years, 9 months ago (2016-03-25 23:47:33 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-26 00:47:34 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 00:48:54 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0
Cr-Commit-Position: refs/heads/master@{#383423}

Powered by Google App Engine
This is Rietveld 408576698