Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1832243002: Mojo C++ bindings: change sync_method_unittests to typed tests. (Closed)

Created:
4 years, 8 months ago by yzshen1
Modified:
4 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@34_sync_watcher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: change sync_method_unittests to typed tests. So that we can easily use the same tests to test the behavior of both Router and MultiplexRouter. BUG=577699 Committed: https://crrev.com/a4d969159adc823fe5fbe9a995241e6325e85cb6 Cr-Commit-Position: refs/heads/master@{#383459}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -67 lines) Patch
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 1 15 chunks +102 lines, -67 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
yzshen1
Hi, John. Would you please take a look? Thanks! The change of actually using those ...
4 years, 8 months ago (2016-03-25 22:22:47 UTC) #2
jam
lgtm
4 years, 8 months ago (2016-03-25 22:32:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832243002/20001
4 years, 8 months ago (2016-03-25 23:24:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-26 01:14:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832243002/20001
4 years, 8 months ago (2016-03-26 17:45:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-26 17:51:00 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-26 17:51:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4d969159adc823fe5fbe9a995241e6325e85cb6
Cr-Commit-Position: refs/heads/master@{#383459}

Powered by Google App Engine
This is Rietveld 408576698