cc : Use effect tree to determine if a layer is inside replica

cc : Use effect tree to determine if a layer is inside replica

This CL also addes target_id to effect tree.

BUG=597477
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3
Cr-Commit-Position: refs/heads/master@{#383748}

[jaydasika, 2016-03-25 22:01:32]

Description was changed from

==========
cc : Use effect tree to determine if a layer is inside replica

This CL also addes target_id to effect tree.

BUG=597477
==========

to

==========
cc : Use effect tree to determine if a layer is inside replica

This CL also addes target_id to effect tree.

BUG=597477
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-25 22:17:19]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, enne@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-03-25 22:17:20]

PTAL

[ajuma, 2016-03-29 13:41:10]

lgtm

https://codereview.chromium.org/1832233002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1832233002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:1586: inside_replica = true;
We can early-return here.

https://codereview.chromium.org/1832233002/diff/20001/cc/trees/property_tree.h
File cc/trees/property_tree.h (right):

https://codereview.chromium.org/1832233002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.h:275: // render surface's target.
For a node that corresponds to a surface, it looks like the target_id is the
node's own id, not the id of the surface's target. If that's the intended
behavior, please clarify the comment.

[jaydasika, 2016-03-29 16:03:46]

https://codereview.chromium.org/1832233002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1832233002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:1586: inside_replica = true;
On 2016/03/29 13:41:10, ajuma wrote:
> We can early-return here.

Done.

https://codereview.chromium.org/1832233002/diff/20001/cc/trees/property_tree.h
File cc/trees/property_tree.h (right):

https://codereview.chromium.org/1832233002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.h:275: // render surface's target.
On 2016/03/29 13:41:10, ajuma wrote:
> For a node that corresponds to a surface, it looks like the target_id is the
> node's own id, not the id of the surface's target. If that's the intended
> behavior, please clarify the comment.

Done.

[jaydasika, 2016-03-29 16:03:49]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-03-29 16:03:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1832233002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-29 16:04:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832233002/40001

[jaydasika, 2016-03-29 16:17:46]

Patchset #4 (id:60001) has been deleted

[jaydasika, 2016-03-29 16:18:22]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-03-29 16:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1832233002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-29 16:18:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832233002/40001

[commit-bot: I haz the power, 2016-03-29 17:06:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 17:07:39]

Description was changed from

==========
cc : Use effect tree to determine if a layer is inside replica

This CL also addes target_id to effect tree.

BUG=597477
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Use effect tree to determine if a layer is inside replica

This CL also addes target_id to effect tree.

BUG=597477
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3
Cr-Commit-Position: refs/heads/master@{#383748}
==========

[commit-bot: I haz the power, 2016-03-29 17:07:40]

Patchset 3 (id:??) landed as
https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3
Cr-Commit-Position: refs/heads/master@{#383748}