src/effects/SkLayerDrawLooper.cpp - Issue 1832223002: switch xfermodes over to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLayerDrawLooper.cpp

Issue 1832223002: switch xfermodes over to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLayerDrawLooper.cpp

diff --git a/src/effects/SkLayerDrawLooper.cpp b/src/effects/SkLayerDrawLooper.cpp

index 0a5c4f9df3209eb954db2de1bc5d22444dda0c51..b3430bb1e4a5e22a6c2d42f36fe3a333f725b3c4 100644

--- a/src/effects/SkLayerDrawLooper.cpp

+++ b/src/effects/SkLayerDrawLooper.cpp

@@ -104,7 +104,7 @@ void SkLayerDrawLooper::LayerDrawLooperContext::ApplyInfo(

dst->setColorFilter(sk_ref_sp(src.getColorFilter()));

}

if (bits & kXfermode_Bit) {

- dst->setXfermode(src.getXfermode());

+ dst->setXfermode(sk_ref_sp(src.getXfermode()));

}

// we don't override these