switch xfermodes over to sk_sp

include/effects/SkXfermodeImageFilter.h

 /*
  * Copyright 2013 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkXfermodeImageFilter_DEFINED
 #define SkXfermodeImageFilter_DEFINED
 
 #include "SkImageFilter.h"
 
 class SkBitmap;
 class SkXfermode;
 
 class SK_API SkXfermodeImageFilter : public SkImageFilter {
     /**
      * This filter takes an xfermode, and uses it to composite the foreground
      * over the background.  If foreground or background is NULL, the input
      * bitmap (src) is used instead.
       */
 
 public:
+    static sk_sp<SkImageFilter> Make(sk_sp<SkXfermode> mode, SkImageFilter* background,

[dogben, 2016/04/01 20:08:52]

Shouldn't this accept background and foreground as sk_sp?

[reed1, 2016/04/02 14:26:56]

Indeed. Subsequent changes will fix those. Since (at the time of this CL)
imagefilter factories had not been converted to return sk_sp, that aspect was
left alone for now.

[robertphillips, 2016/04/03 18:26:46]

Yep - I'm slowly churning my way through all the ImageFilters.

+                                     SkImageFilter* foreground, const CropRect* cropRect);
+    static sk_sp<SkImageFilter> Make(sk_sp<SkXfermode> mode, SkImageFilter* background) {
+        return Make(std::move(mode), background, nullptr, nullptr);
+    }
+#ifdef SK_SUPPORT_LEGACY_XFERMODE_PTR
     static SkImageFilter* Create(SkXfermode* mode, SkImageFilter* background,
                                  SkImageFilter* foreground = NULL,
                                  const CropRect* cropRect = NULL) {
-        SkImageFilter* inputs[2] = { background, foreground };
-        return new SkXfermodeImageFilter(mode, inputs, cropRect);
+        return Make(sk_ref_sp(mode), background, foreground, cropRect).release();
     }
-
+#endif
+    
     SK_TO_STRING_OVERRIDE()
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkXfermodeImageFilter)
 
     bool onFilterImageDeprecated(Proxy* proxy,
                                  const SkBitmap& src,
                                  const Context& ctx,
                                  SkBitmap* dst,
                                  SkIPoint* offset) const override;
 #if SK_SUPPORT_GPU
     bool canFilterImageGPU() const override;
     bool filterImageGPUDeprecated(Proxy* proxy, const SkBitmap& src, const Context& ctx,
                                   SkBitmap* result, SkIPoint* offset) const override;
 #endif
 
 protected:
-    SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* inputs[2],
+    SkXfermodeImageFilter(sk_sp<SkXfermode> mode, SkImageFilter* inputs[2],
                           const CropRect* cropRect);
     void flatten(SkWriteBuffer&) const override;
 
 private:
-    SkAutoTUnref<SkXfermode> fMode;
+    sk_sp<SkXfermode> fMode;
     typedef SkImageFilter INHERITED;
 };
 
 #endif