[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
TBR=brettw@chromium.org

Committed: https://crrev.com/277738b70c694a1017dfce3305badf4c319bed30
Cr-Commit-Position: refs/heads/master@{#383382}

[aizatsky, 2016-03-25 20:52:30]

Description was changed from

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
==========

to

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
==========

[aizatsky, 2016-03-25 20:52:30]

aizatsky@chromium.org changed reviewers:
+ brettw@chromium.org, inferno@chromium.org, mmoroz@chromium.org

[inferno, 2016-03-25 20:57:55]

inferno@chromium.org changed reviewers:
+ kcc@chromium.org

[inferno, 2016-03-25 20:57:55]

lgtm with nits

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/BUI...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/BUI...
build/config/sanitizers/BUILD.gn:249: if (is_libfuzzer_ubsan) {
please rename this to is_ubsan_security or something like that since we can use
this flag outside of libfuzzer too.

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/san...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/san...
build/config/sanitizers/sanitizers.gni:53: # gradually. Eventually should catch
up with is_ubsan and should be removed.
Can you fix the comment to indicate this is a flag that enable some core
security features instead and will later be removed.

[aizatsky, 2016-03-25 21:02:45]

ptal

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/BUI...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/BUI...
build/config/sanitizers/BUILD.gn:249: if (is_libfuzzer_ubsan) {
On 2016/03/25 20:57:55, inferno wrote:
> please rename this to is_ubsan_security or something like that since we can
use
> this flag outside of libfuzzer too.

Done.

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/san...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/1832213002/diff/1/build/config/sanitizers/san...
build/config/sanitizers/sanitizers.gni:53: # gradually. Eventually should catch
up with is_ubsan and should be removed.
On 2016/03/25 20:57:55, inferno wrote:
> Can you fix the comment to indicate this is a flag that enable some core
> security features instead and will later be removed.

Done.

[inferno, 2016-03-25 21:05:37]

The CQ bit was checked by inferno@chromium.org

[inferno, 2016-03-25 21:05:38]

lgtm

[commit-bot: I haz the power, 2016-03-25 21:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832213002/20001

[inferno, 2016-03-25 21:06:21]

Description was changed from

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
==========

to

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
TBR=brettw@chromium.org
==========

[Dirk Pranke, 2016-03-25 21:16:11]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-25 21:16:11]

lgtm

[commit-bot: I haz the power, 2016-03-25 22:14:40]

Description was changed from

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
TBR=brettw@chromium.org
==========

to

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-03-25 22:14:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 22:16:23]

Description was changed from

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
TBR=brettw@chromium.org
==========

to

==========
[libfuzzer] separate libfuzzer ubsan configuration and ubsan build config setup.

BUG=596650
TBR=brettw@chromium.org

Committed: https://crrev.com/277738b70c694a1017dfce3305badf4c319bed30
Cr-Commit-Position: refs/heads/master@{#383382}
==========

[commit-bot: I haz the power, 2016-03-25 22:16:24]

Patchset 2 (id:??) landed as
https://crrev.com/277738b70c694a1017dfce3305badf4c319bed30
Cr-Commit-Position: refs/heads/master@{#383382}

[ronaldvickers1970, 2016-03-25 22:51:19]

ronaldvickers1970@gmail.com changed reviewers:
+ ronaldvickers1970@gmail.com