Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: core/fxcrt/fxcrt_windows.cpp

Issue 1832173003: Remove FX_DWORD from core/ and delete definition (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/fxcrt_windows.h ('k') | core/fxcrt/include/fx_basic.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/fxcrt_windows.cpp
diff --git a/core/fxcrt/fxcrt_windows.cpp b/core/fxcrt/fxcrt_windows.cpp
index 61c0eb6e392511efc950cd23264821605c14b41a..340d22585f64fb6aaf6c7913182b857da438e258 100644
--- a/core/fxcrt/fxcrt_windows.cpp
+++ b/core/fxcrt/fxcrt_windows.cpp
@@ -12,10 +12,10 @@
IFXCRT_FileAccess* FXCRT_FileAccess_Create() {
return new CFXCRT_FileAccess_Win64;
}
-void FXCRT_Windows_GetFileMode(FX_DWORD dwMode,
- FX_DWORD& dwAccess,
- FX_DWORD& dwShare,
- FX_DWORD& dwCreation) {
+void FXCRT_Windows_GetFileMode(uint32_t dwMode,
+ uint32_t& dwAccess,
+ uint32_t& dwShare,
+ uint32_t& dwCreation) {
dwAccess = GENERIC_READ;
dwShare = FILE_SHARE_READ | FILE_SHARE_WRITE;
if (!(dwMode & FX_FILEMODE_ReadOnly)) {
@@ -41,11 +41,11 @@ CFXCRT_FileAccess_Win64::~CFXCRT_FileAccess_Win64() {
Close();
}
FX_BOOL CFXCRT_FileAccess_Win64::Open(const CFX_ByteStringC& fileName,
- FX_DWORD dwMode) {
+ uint32_t dwMode) {
if (m_hFile) {
return FALSE;
}
- FX_DWORD dwAccess, dwShare, dwCreation;
+ uint32_t dwAccess, dwShare, dwCreation;
FXCRT_Windows_GetFileMode(dwMode, dwAccess, dwShare, dwCreation);
m_hFile = ::CreateFileA(fileName.GetCStr(), dwAccess, dwShare, NULL,
dwCreation, FILE_ATTRIBUTE_NORMAL, NULL);
@@ -55,11 +55,11 @@ FX_BOOL CFXCRT_FileAccess_Win64::Open(const CFX_ByteStringC& fileName,
return m_hFile != NULL;
}
FX_BOOL CFXCRT_FileAccess_Win64::Open(const CFX_WideStringC& fileName,
- FX_DWORD dwMode) {
+ uint32_t dwMode) {
if (m_hFile) {
return FALSE;
}
- FX_DWORD dwAccess, dwShare, dwCreation;
+ uint32_t dwAccess, dwShare, dwCreation;
FXCRT_Windows_GetFileMode(dwMode, dwAccess, dwShare, dwCreation);
m_hFile = ::CreateFileW((LPCWSTR)fileName.GetPtr(), dwAccess, dwShare, NULL,
dwCreation, FILE_ATTRIBUTE_NORMAL, NULL);
« no previous file with comments | « core/fxcrt/fxcrt_windows.h ('k') | core/fxcrt/include/fx_basic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698