[sql] Database recovery system for Shortcuts.

components/omnibox/browser/shortcuts_database_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/shortcuts_database.h"
 
 #include <stddef.h>
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/format_macros.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "components/omnibox/browser/autocomplete_match_type.h"
 #include "components/omnibox/browser/shortcuts_constants.h"
 #include "sql/statement.h"
+#include "sql/test/scoped_error_expecter.h"
 #include "sql/test/test_helpers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/page_transition_types.h"
 
 using base::ASCIIToUTF16;
 
 // Helpers --------------------------------------------------------------------
 
 namespace {
 
@@ skipping 196 matching lines @@
 TEST(ShortcutsDatabaseMigrationTest, MigrateTableAddFillIntoEdit) {
   // Use the pre-v0 test file to create a test database in a temp dir.
   base::FilePath sql_path = GetTestDataDir().AppendASCII(
 #if defined(OS_ANDROID)
       "Shortcuts.v1.sql");
 #else
       "Shortcuts.no_fill_into_edit.sql");
 #endif
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
-  base::FilePath db_path(temp_dir.path().AppendASCII("TestShortcuts1.db"));
+  base::FilePath db_path(temp_dir.path().AppendASCII("TestShortcuts.db"));
   ASSERT_TRUE(sql::test::CreateDatabaseFromSQL(db_path, sql_path));
 
   CheckV2ColumnExistence(db_path, false);
 
   // Create a ShortcutsDatabase from the test database, which will migrate the
   // test database to the current version.
   {
     scoped_refptr<ShortcutsDatabase> db(new ShortcutsDatabase(db_path));
     db->Init();
   }
@@ skipping 23 matching lines @@
 #if !defined(OS_WIN)
   EXPECT_TRUE(temp_dir.Delete());
 #endif
 }
 
 TEST(ShortcutsDatabaseMigrationTest, MigrateV0ToV1) {
   // Use the v0 test file to create a test database in a temp dir.
   base::FilePath sql_path = GetTestDataDir().AppendASCII("Shortcuts.v0.sql");
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
-  base::FilePath db_path(temp_dir.path().AppendASCII("TestShortcuts2.db"));
+  base::FilePath db_path(temp_dir.path().AppendASCII("TestShortcuts.db"));
   ASSERT_TRUE(sql::test::CreateDatabaseFromSQL(db_path, sql_path));
 
   // Create a ShortcutsDatabase from the test database, which will migrate the
   // test database to the current version.
   {
     scoped_refptr<ShortcutsDatabase> db(new ShortcutsDatabase(db_path));
     db->Init();
   }
 
   // Check that all the old type values got converted to new values.
   sql::Connection connection;
   ASSERT_TRUE(connection.Open(db_path));
   sql::Statement statement(connection.GetUniqueStatement(
       "SELECT count(1) FROM omni_box_shortcuts WHERE type in (9, 10, 11, 12)"));
   ASSERT_TRUE(statement.is_valid());
   while (statement.Step())
     EXPECT_EQ(0, statement.ColumnInt(0));
   EXPECT_TRUE(statement.Succeeded());
 #if !defined(OS_WIN)
   EXPECT_TRUE(temp_dir.Delete());
 #endif
 }
+
+TEST(ShortcutsDatabaseMigrationTest, Recovery1) {
+#if defined(OS_ANDROID)
+  char kBasename[] = "Shortcuts.v1.sql";
+#else
+  char kBasename[] = "Shortcuts.no_fill_into_edit.sql";
+#endif
+  // Use the pre-v0 test file to create a test database in a temp dir.
+  base::FilePath sql_path = GetTestDataDir().AppendASCII(kBasename);
+  base::ScopedTempDir temp_dir;
+  ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+  base::FilePath db_path(temp_dir.path().AppendASCII("TestShortcuts.db"));
+  ASSERT_TRUE(sql::test::CreateDatabaseFromSQL(db_path, sql_path));
+
+  // Capture the row count from the golden file before corrupting the database.
+  const char kCountSql[] = "SELECT COUNT(*) FROM omni_box_shortcuts";
+  int row_count;
+  {
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(db_path));
+    sql::Statement statement(connection.GetUniqueStatement(kCountSql));
+    ASSERT_TRUE(statement.is_valid());
+    ASSERT_TRUE(statement.Step());
+    row_count = statement.ColumnInt(0);
+  }
+
+  // Break the database.
+  ASSERT_TRUE(sql::test::CorruptSizeInHeader(db_path));
+
+  // Verify that the database is broken.  The corruption will prevent reading
+  // the schema, causing the prepared statement to not compile.
+  {
+    sql::test::ScopedErrorExpecter expecter;
+    expecter.ExpectError(SQLITE_CORRUPT);
+
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(db_path));
+    sql::Statement statement(connection.GetUniqueStatement(kCountSql));
+    ASSERT_FALSE(statement.is_valid());
+
+    ASSERT_TRUE(expecter.SawExpectedErrors());
+  }
+
+  // The sql::Connection::Open() called by ShortcutsDatabase::Init() will hit
+  // the corruption, the error callback will recover and poison the database,
+  // then Open() will retry successfully, allowing Init() to succeed.
+  {
+    sql::test::ScopedErrorExpecter expecter;
+    expecter.ExpectError(SQLITE_CORRUPT);
+
+    scoped_refptr<ShortcutsDatabase> db(new ShortcutsDatabase(db_path));
+    ASSERT_TRUE(db->Init());
+
+    ASSERT_TRUE(expecter.SawExpectedErrors());
+  }
+
+  CheckV2ColumnExistence(db_path, true);
+
+  // The previously-broken statement works and all of the data should have been
+  // recovered.
+  {
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(db_path));
+    sql::Statement statement(connection.GetUniqueStatement(kCountSql));
+    ASSERT_TRUE(statement.is_valid());
+    ASSERT_TRUE(statement.Step());
+    EXPECT_EQ(row_count, statement.ColumnInt(0));
+  }
+}