Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1832153002: [ios] Added DEPS file to ios/web/shell. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 9 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Added DEPS file to ios/web/shell. This DEPS file temporary whitelists current includes. BUG=597997 Committed: https://crrev.com/e9d4db6501a02924376d91f9867cd663744a85e9 Cr-Commit-Position: refs/heads/master@{#383356}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A ios/web/shell/DEPS View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-25 18:36:42 UTC) #3
Jackie Quinn
lgtm, with a comment nit. https://codereview.chromium.org/1832153002/diff/1/ios/web/shell/DEPS File ios/web/shell/DEPS (right): https://codereview.chromium.org/1832153002/diff/1/ios/web/shell/DEPS#newcode7 ios/web/shell/DEPS:7: # TODO(crbug.com/597997) remove these ...
4 years, 9 months ago (2016-03-25 18:49:16 UTC) #4
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/1832153002/diff/1/ios/web/shell/DEPS File ios/web/shell/DEPS (right): https://codereview.chromium.org/1832153002/diff/1/ios/web/shell/DEPS#newcode7 ios/web/shell/DEPS:7: # TODO(crbug.com/597997) remove these exceptions. web shell must ...
4 years, 9 months ago (2016-03-25 19:59:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832153002/20001
4 years, 9 months ago (2016-03-25 19:59:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 20:59:07 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:02:11 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9d4db6501a02924376d91f9867cd663744a85e9
Cr-Commit-Position: refs/heads/master@{#383356}

Powered by Google App Engine
This is Rietveld 408576698