Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 183213002: Remove hack disabling goma when building using Xcode clang (Closed)

Created:
6 years, 9 months ago by sdefresne
Modified:
6 years, 9 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove hack disabling goma when building using Xcode clang The last version of goma (54) no longer mistake clang for gcc when it is accessed using the cc symlink in the path. BUG=315114 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sdefresne
Please have a look.
6 years, 9 months ago (2014-02-27 15:10:05 UTC) #1
blundell
lgtm
6 years, 9 months ago (2014-02-27 15:12:25 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 9 months ago (2014-02-27 15:18:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/183213002/1
6 years, 9 months ago (2014-02-27 15:19:01 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 18:46:33 UTC) #5
Message was sent while issue was closed.
Change committed as 253881

Powered by Google App Engine
This is Rietveld 408576698