Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832113003: Replace CFX_DWordArray with CFX_ArrayTemplate<FX_DWORD>. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_DWordArray with CFX_ArrayTemplate<FX_DWORD>. First step to getting rid of FX_DWORD. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/46c8b1e3202ab5ae3663141dc25bec3b4360322e

Patch Set 1 : expand array #

Patch Set 2 : kill defn #

Patch Set 3 : Re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M core/fpdfapi/fpdf_edit/editint.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_edit/include/cpdf_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/fx_basic.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.h View 3 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Dan, please review. Nice patch for a friday.
4 years, 9 months ago (2016-03-25 20:22:58 UTC) #4
Tom Sepez
Oliver, please review (no Dan today).
4 years, 9 months ago (2016-03-25 20:24:19 UTC) #6
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-25 20:34:39 UTC) #7
Tom Sepez
4 years, 9 months ago (2016-03-25 20:42:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:50001) manually as
46c8b1e3202ab5ae3663141dc25bec3b4360322e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698