Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1832113002: Statically link the CRT so that clang-cl can run in wine on goma (Closed)

Created:
4 years, 9 months ago by Reid Kleckner
Modified:
4 years, 9 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Statically link the CRT so that clang-cl can run in wine on goma Now we have these deps: $ dumpbin /dependents third_party\llvm-bootstrap\bin\clang-cl.exe ... SHELL32.dll KERNEL32.dll ADVAPI32.dll R=hans@chromium.org BUG=597854 NOTRY=True Committed: https://crrev.com/260528431247b958483c9f7f2e1c6525aba077d7 Cr-Commit-Position: refs/heads/master@{#383311}

Patch Set 1 #

Patch Set 2 : reupload with right diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Reid Kleckner
4 years, 9 months ago (2016-03-25 17:29:05 UTC) #1
Reid Kleckner
reupload with right diff
4 years, 9 months ago (2016-03-25 17:30:32 UTC) #2
hans
lgtm
4 years, 9 months ago (2016-03-25 18:04:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832113002/20001
4 years, 9 months ago (2016-03-25 18:05:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 18:10:17 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 18:11:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/260528431247b958483c9f7f2e1c6525aba077d7
Cr-Commit-Position: refs/heads/master@{#383311}

Powered by Google App Engine
This is Rietveld 408576698