Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1832093002: Add -fms-compatibility-version=19 to the clang-cl self-host (Closed)

Created:
4 years, 9 months ago by Reid Kleckner
Modified:
4 years, 9 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add -fms-compatibility-version=19 to the clang-cl self-host Otherwise, we get errors about char16_t and char32_t during the stage 2 build. Also, fix a bug where cflags, cxxflags, and ldflags all pointed to the same list. R=hans@chromium.org BUG=597854 Committed: https://chromium.googlesource.com/chromium/src/+/9be8ca7b77549c46f9a51e991d25e1a509664fd5

Patch Set 1 #

Patch Set 2 : Fix a bug list thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/clang/scripts/update.py View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Reid Kleckner
4 years, 9 months ago (2016-03-25 16:17:50 UTC) #1
hans
lgtm
4 years, 9 months ago (2016-03-25 16:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832093002/20001
4 years, 9 months ago (2016-03-25 16:47:59 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9be8ca7b77549c46f9a51e991d25e1a509664fd5 Cr-Commit-Position: refs/heads/master@{#383288}
4 years, 9 months ago (2016-03-25 16:56:12 UTC) #8
Reid Kleckner
Committed patchset #2 (id:20001) manually as 9be8ca7b77549c46f9a51e991d25e1a509664fd5 (presubmit successful).
4 years, 9 months ago (2016-03-25 16:57:05 UTC) #10
Nico
On 2016/03/25 16:57:05, Reid Kleckner wrote: > Committed patchset #2 (id:20001) manually as > 9be8ca7b77549c46f9a51e991d25e1a509664fd5 ...
4 years, 9 months ago (2016-03-25 19:53:31 UTC) #11
Reid Kleckner
4 years, 9 months ago (2016-03-25 22:50:02 UTC) #12
Message was sent while issue was closed.
On 2016/03/25 19:53:31, Nico (away until Mon Mar 27) wrote:
> On 2016/03/25 16:57:05, Reid Kleckner wrote:
> > Committed patchset #2 (id:20001) manually as
> > 9be8ca7b77549c46f9a51e991d25e1a509664fd5 (presubmit successful).
> 
> Should the fmsc bits be in the upstream cmake config? Everyone doing
bootstraps
> on Windows will need this, right?

Yes, but I didn't want to pick a new LLVM revision. We can copy the cmake bits I
added to compiler-rt, and remove this later.

Powered by Google App Engine
This is Rietveld 408576698