Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832073002: Fix GN bootstrap on Linux (Closed)

Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap on Linux Generate base/allocator/features.h BUG=none Committed: https://crrev.com/1e171070a1dcf30505bc1f8945401b1ebbc092e0 Cr-Commit-Position: refs/heads/master@{#384228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 7 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2016-03-25 14:34:00 UTC) #2
Dirk Pranke
Brett's probably a better reviewer for this than me ...
4 years, 9 months ago (2016-03-25 18:59:09 UTC) #4
brettw
lgtm
4 years, 8 months ago (2016-03-30 21:20:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832073002/1
4 years, 8 months ago (2016-03-31 05:40:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/151332)
4 years, 8 months ago (2016-03-31 06:10:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832073002/1
4 years, 8 months ago (2016-03-31 09:02:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 09:19:13 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 09:20:05 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1e171070a1dcf30505bc1f8945401b1ebbc092e0
Cr-Commit-Position: refs/heads/master@{#384228}

Powered by Google App Engine
This is Rietveld 408576698