Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1832053003: Fix typo in SkTLazy copy ctor. src is a reference, not a pointer. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkTLazy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
mtklein_C
4 years, 9 months ago (2016-03-25 15:47:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832053003/1
4 years, 9 months ago (2016-03-25 15:47:20 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-25 15:47:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/8096)
4 years, 9 months ago (2016-03-25 15:48:53 UTC) #8
bsalomon
lgtm
4 years, 9 months ago (2016-03-25 15:53:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832053003/1
4 years, 9 months ago (2016-03-25 16:10:42 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:11:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5443f1b6bab26e0ee010d8b255f9ab6498a096ea

Powered by Google App Engine
This is Rietveld 408576698