Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1832053002: MIPS64: Fix '[es6] Faster implementation of OrdinaryHasInstance.' (Closed)

Created:
4 years, 9 months ago by balazs.kilvady
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix '[es6] Faster implementation of OrdinaryHasInstance.' Port b6419fa2298de8e292c6bed0bd20de5c96f7da12 Now implemented as a builtin that delegates to the InstanceOfStub. That stub was parameterized to fallback to either Runtime_InstanceOf or to Runtime_OrdinaryHasInstance depending on the --harmony-instanceof flag. Once the feature stabilizes and the flag is no longer needed, we can get rid of this parameterization again. BUG=v8:4447 LOG=n Committed: https://crrev.com/ed2b31585e769608948d898cec5da194d585538a Cr-Commit-Position: refs/heads/master@{#35072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
balazs.kilvady
4 years, 9 months ago (2016-03-25 13:57:13 UTC) #2
balazs.kilvady
PTAL.
4 years, 9 months ago (2016-03-25 15:12:59 UTC) #3
akos.palfi.imgtec
LGTM
4 years, 9 months ago (2016-03-25 16:02:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832053002/1
4 years, 9 months ago (2016-03-25 16:05:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 16:25:06 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:26:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed2b31585e769608948d898cec5da194d585538a
Cr-Commit-Position: refs/heads/master@{#35072}

Powered by Google App Engine
This is Rietveld 408576698