Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

Issue 1831993002: Handle position:absolute candidates correctly in ScrollAnchor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ScrollAnchor.h" 5 #include "core/layout/ScrollAnchor.h"
6 6
7 #include "core/layout/LayoutBox.h" 7 #include "core/layout/LayoutBox.h"
8 #include "core/layout/LayoutTestHelper.h" 8 #include "core/layout/LayoutTestHelper.h"
9 #include "core/paint/PaintLayerScrollableArea.h" 9 #include "core/paint/PaintLayerScrollableArea.h"
10 10
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 "<div id=f>fixed</div>" 173 "<div id=f>fixed</div>"
174 "<div id=c>content</div>"); 174 "<div id=c>content</div>");
175 175
176 scrollLayoutViewport(DoubleSize(0, 50)); 176 scrollLayoutViewport(DoubleSize(0, 50));
177 177
178 setHeight(document().body(), 1100); 178 setHeight(document().body(), 1100);
179 EXPECT_EQ(document().getElementById("c")->layoutObject(), 179 EXPECT_EQ(document().getElementById("c")->layoutObject(),
180 scrollAnchor(layoutViewport()).anchorObject()); 180 scrollAnchor(layoutViewport()).anchorObject());
181 } 181 }
182 182
183 TEST_F(ScrollAnchorTest, ExcludeAbsolutePosition)
184 {
185 setBodyInnerHTML(
186 "<style>"
187 " body { margin: 0; }"
188 " #scroller { overflow: scroll; width: 500px; height: 400px; }"
189 " #space { height: 1000px; }"
190 " #abs {"
191 " position: absolute; background-color: red;"
192 " left: 200px; top: 100px; width: 100px; height: 100px;"
193 " }"
194 " #rel {"
195 " position: relative; background-color: green;"
196 " left: 50px; top: 100px; width: 100px; height: 75px;"
197 " }"
198 "</style>"
199 "<div id='scroller'><div id='space'>"
200 " <div id='abs'></div>"
201 " <div id='rel'></div>"
202 "</div></div>");
203
204 Element* scrollerElement = document().getElementById("scroller");
205 ScrollableArea* scroller = scrollerForElement(scrollerElement);
206 Element* absPos = document().getElementById("abs");
207 Element* relPos = document().getElementById("rel");
208
209 scroller->scrollBy(DoubleSize(0, 25), UserScroll);
210 setHeight(relPos, 100);
211
212 // When the scroller is position:static, the anchor cannot be position:absol ute.
213 EXPECT_EQ(relPos->layoutObject(), scrollAnchor(scroller).anchorObject());
214
215 scrollerElement->setAttribute(HTMLNames::styleAttr, "position: relative");
216 scroller->scrollBy(DoubleSize(0, 25), UserScroll);
217 setHeight(relPos, 125);
218
219 // When the scroller is position:relative, the anchor may be position:absolu te.
220 EXPECT_EQ(absPos->layoutObject(), scrollAnchor(scroller).anchorObject());
221 }
222
183 class ScrollAnchorCornerTest : public ScrollAnchorTest { 223 class ScrollAnchorCornerTest : public ScrollAnchorTest {
184 protected: 224 protected:
185 void checkCorner(const AtomicString& id, Corner corner, DoublePoint startPos , DoubleSize expectedAdjustment) 225 void checkCorner(const AtomicString& id, Corner corner, DoublePoint startPos , DoubleSize expectedAdjustment)
186 { 226 {
187 ScrollableArea* viewport = layoutViewport(); 227 ScrollableArea* viewport = layoutViewport();
188 Element* element = document().getElementById(id); 228 Element* element = document().getElementById(id);
189 229
190 viewport->setScrollPosition(startPos, UserScroll); 230 viewport->setScrollPosition(startPos, UserScroll);
191 element->setAttribute(HTMLNames::classAttr, "big"); 231 element->setAttribute(HTMLNames::classAttr, "big");
192 update(); 232 update();
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 "<div id=c></div>" 266 "<div id=c></div>"
227 "<div id=d></div>"); 267 "<div id=d></div>");
228 268
229 checkCorner("a", Corner::BottomRight, DoublePoint(20, 20), DoubleSize(+400 , +300)); 269 checkCorner("a", Corner::BottomRight, DoublePoint(20, 20), DoubleSize(+400 , +300));
230 checkCorner("b", Corner::BottomLeft, DoublePoint(420, 20), DoubleSize(-400 , +300)); 270 checkCorner("b", Corner::BottomLeft, DoublePoint(420, 20), DoubleSize(-400 , +300));
231 checkCorner("c", Corner::TopRight, DoublePoint(20, 320), DoubleSize(+400 , -300)); 271 checkCorner("c", Corner::TopRight, DoublePoint(20, 320), DoubleSize(+400 , -300));
232 checkCorner("d", Corner::TopLeft, DoublePoint(420, 320), DoubleSize(-400 , -300)); 272 checkCorner("d", Corner::TopLeft, DoublePoint(420, 320), DoubleSize(-400 , -300));
233 } 273 }
234 274
235 } 275 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698