Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1831983003: SkMipMap::Build supports 1xN and Nx1 inputs, so remove the special case from the test harness. Updat (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
Reviewers:
cblume, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkMipMap::Build supports 1xN and Nx1 inputs, so remove the special case from the test harness. Update a no-longer-correct comment. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831983003 Committed: https://skia.googlesource.com/skia/+/9cf31f40fb5df6b6b914e087394c40b8303e5e32

Patch Set 1 #

Patch Set 2 : Update no-longer-correct comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tests/MipMapTest.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Brian Osman
4 years, 9 months ago (2016-03-25 18:40:32 UTC) #4
reed1
lgtm
4 years, 9 months ago (2016-03-25 19:28:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831983003/20001
4 years, 9 months ago (2016-03-25 19:39:57 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 19:55:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9cf31f40fb5df6b6b914e087394c40b8303e5e32

Powered by Google App Engine
This is Rietveld 408576698