Issue 1831953002: Fix shared_library build of content_decoder_tool

Issue 1831953002: Fix shared_library build of content_decoder_tool (Closed)

Created:
4 years, 9 months ago by hans

Modified:
4 years, 9 months ago

Reviewers:
gabadie

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix shared_library build of content_decoder_tool The build was failing like this: $ GYP_DEFINES="component=shared_library" build/gyp_chromium $ ninja -C out/Release content_decoder_tool [...] obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function net::MockFilterContext::MockFilterContext(): error: undefined reference to 'GURL::GURL()' obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function net::MockFilterContext::~MockFilterContext(): error: undefined reference to 'GURL::~GURL()' obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to 'GURL::GURL(GURL const&)' obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to 'GURL::operator=(GURL)' obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to 'GURL::~GURL()' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. BUG=582080 TBR=gabadie Committed: https://chromium.googlesource.com/chromium/src/+/f369bd1c009492dfc45215f98db0bd01f5234b00

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	net/net.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 9 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hans

Description was changed from ========== Fix shared_library build of content_decoder_tool The build was failing like ...

4 years, 9 months ago (2016-03-24 23:47:58 UTC) #1

Description was changed from

==========
Fix shared_library build of content_decoder_tool

The build was failing like this:
$ GYP_DEFINES="component=shared_library" build/gyp_chromium
$ ninja -C out/Release content_decoder_tool
[...]
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::MockFilterContext(): error: undefined reference to
'GURL::GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::~MockFilterContext(): error: undefined reference to
'GURL::~GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::GURL(GURL const&)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::operator=(GURL)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::~GURL()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

BUG=582080
==========

to

==========
Fix shared_library build of content_decoder_tool

The build was failing like this:
$ GYP_DEFINES="component=shared_library" build/gyp_chromium
$ ninja -C out/Release content_decoder_tool
[...]
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::MockFilterContext(): error: undefined reference to
'GURL::GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::~MockFilterContext(): error: undefined reference to
'GURL::~GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::GURL(GURL const&)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::operator=(GURL)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::~GURL()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

BUG=582080
TBR=gabadie
==========

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831953002/1

4 years, 9 months ago (2016-03-24 23:48:47 UTC) #4

commit-bot: I haz the power

Description was changed from ========== Fix shared_library build of content_decoder_tool The build was failing like ...

4 years, 9 months ago (2016-03-25 00:49:20 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Fix shared_library build of content_decoder_tool

The build was failing like this:
$ GYP_DEFINES="component=shared_library" build/gyp_chromium
$ ninja -C out/Release content_decoder_tool
[...]
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::MockFilterContext(): error: undefined reference to
'GURL::GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::~MockFilterContext(): error: undefined reference to
'GURL::~GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::GURL(GURL const&)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::operator=(GURL)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::~GURL()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

BUG=582080
TBR=gabadie
==========

to

==========
Fix shared_library build of content_decoder_tool

The build was failing like this:
$ GYP_DEFINES="component=shared_library" build/gyp_chromium
$ ninja -C out/Release content_decoder_tool
[...]
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::MockFilterContext(): error: undefined reference to
'GURL::GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::~MockFilterContext(): error: undefined reference to
'GURL::~GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::GURL(GURL const&)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::operator=(GURL)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::~GURL()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

BUG=582080
TBR=gabadie

Committed: https://crrev.com/f369bd1c009492dfc45215f98db0bd01f5234b00
Cr-Commit-Position: refs/heads/master@{#383210}
==========

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f369bd1c009492dfc45215f98db0bd01f5234b00 Cr-Commit-Position: refs/heads/master@{#383210}

4 years, 9 months ago (2016-03-25 00:49:20 UTC) #6

hans

Description was changed from ========== Fix shared_library build of content_decoder_tool The build was failing like ...

4 years, 9 months ago (2016-03-25 00:50:11 UTC) #7

Message was sent while issue was closed.

Description was changed from

==========
Fix shared_library build of content_decoder_tool

The build was failing like this:
$ GYP_DEFINES="component=shared_library" build/gyp_chromium
$ ninja -C out/Release content_decoder_tool
[...]
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::MockFilterContext(): error: undefined reference to
'GURL::GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::~MockFilterContext(): error: undefined reference to
'GURL::~GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::GURL(GURL const&)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::operator=(GURL)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::~GURL()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

BUG=582080
TBR=gabadie

Committed: https://crrev.com/f369bd1c009492dfc45215f98db0bd01f5234b00
Cr-Commit-Position: refs/heads/master@{#383210}
==========

to

==========
Fix shared_library build of content_decoder_tool

The build was failing like this:
$ GYP_DEFINES="component=shared_library" build/gyp_chromium
$ ninja -C out/Release content_decoder_tool
[...]
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::MockFilterContext(): error: undefined reference to
'GURL::GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::~MockFilterContext(): error: undefined reference to
'GURL::~GURL()'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::GURL(GURL const&)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::operator=(GURL)'
obj/net/filter/content_decoder_tool.mock_filter_context.o:../../net/filter/mock_filter_context.cc:function
net::MockFilterContext::GetURL(GURL*) const: error: undefined reference to
'GURL::~GURL()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

BUG=582080
TBR=gabadie

Committed:
https://chromium.googlesource.com/chromium/src/+/f369bd1c009492dfc45215f98db0...
==========

hans

Committed patchset #1 (id:1) manually as f369bd1c009492dfc45215f98db0bd01f5234b00 (presubmit successful).

4 years, 9 months ago (2016-03-25 00:50:12 UTC) #8

gabadie

4 years, 9 months ago (2016-03-25 10:53:54 UTC) #9

Message was sent while issue was closed.

On 2016/03/25 00:50:12, hans wrote:
> Committed patchset #1 (id:1) manually as
> f369bd1c009492dfc45215f98db0bd01f5234b00 (presubmit successful).

lgtm, but you need a owner.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages