Chromium Code Reviews

Issue 183193003: Fix putting of prototype transitions. The length is also subject to GC, just like entry. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix putting of prototype transitions. The length is also subject to GC, just like entry. BUG=347536 LOG=n R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19586

Patch Set 1 #

Patch Set 2 : Adding test #

Unified diffs Side-by-side diffs Stats (+51 lines, -1 line)
M src/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments
A test/mjsunit/regress/regress-put-prototype-transition.js View 1 chunk +49 lines, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 9 months ago (2014-02-27 15:53:29 UTC) #1
danno
lgtm
6 years, 9 months ago (2014-02-27 16:07:14 UTC) #2
Toon Verwaest
6 years, 9 months ago (2014-02-27 16:07:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19586 (tree was closed).

Powered by Google App Engine